-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kernel] Add Kernel component #30672
Conversation
@@ -20,6 +20,7 @@ | |||
"symfony/contracts": "^1.0.2", | |||
"symfony/event-dispatcher": "^4.3", | |||
"symfony/http-foundation": "^4.1.1", | |||
"instinct/kernel": "dev-symfony-master", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is temporary until the component is available on Packagist.
It will be updated to "symfony/kernel": "^4.3"
.
The Travis failure is due to |
456b067
to
711bdc6
Compare
@Korbeil @DanieleGBX I heard that you want to help in order to speed-up the merge of the new Kernel component. Any help are welcome from anyone else wants to help. This PR provides all required code modifications, but we still needs to upgrade the documentation and to write the You can see the full to do list on this PR description. |
711bdc6
to
a835c82
Compare
As it left only to upgrade the documentation then removed |
89e19b9
to
1c0c799
Compare
…ponent is not yet on packagist
Tests are not covered by backward compatibility promise.
…enerated class name is invalid. (drupol)
1c0c799
to
0875cc7
Compare
8049125
to
57be6c0
Compare
what's the ETA of this ? |
@Simperfit As you can see the Dev is done except for the documentation PR that I am not able to do. I am just waiting for the green fire in order to rebase on the latest @nicolas-grekas @dunglas What is the ETA for the code review? What is the priority of this? |
I've just re-read this issue and some other related to the same. I don't think this is something we will ever do. Lately, we have decoupled things more. And Flex did part of the job. But, having big BC breaks is out of the equation with the maturity of the framework. We might do some small steps in this direction, but no big bang. I'm closing for these reasons. |
See #29275 for all details.
To help code review there are one commit per action.
Todo
UPGRADE-6.0.md
(@alquerci)