Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kernel] Add Kernel component #30672

Open
wants to merge 13 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@alquerci
Copy link
Contributor

commented Mar 24, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29275, #27479
License MIT
Doc PR TODO

See #29275 for all details.

To help code review there are one commit per action.

Todo

  • Release specifications, see questions on #29275 (comment)
  • Create the PR to add the kernel component (@alquerci)
    • List test cases
    • Implements tests cases (@alquerci)
    • Write how to migrate on UPGRADE-6.0.md (@alquerci)
  • Create the PR for update the documentation

@alquerci alquerci requested a review from dunglas as a code owner Mar 24, 2019

@alquerci alquerci referenced this pull request Mar 24, 2019

Open

[RFC] [Kernel] Add the Kernel component #29275

0 of 4 tasks complete
@@ -20,6 +20,7 @@
"symfony/contracts": "^1.0.2",
"symfony/event-dispatcher": "^4.3",
"symfony/http-foundation": "^4.1.1",
"instinct/kernel": "dev-symfony-master",

This comment has been minimized.

Copy link
@alquerci

alquerci Mar 24, 2019

Author Contributor

This is temporary until the component is available on Packagist.

It will be updated to "symfony/kernel": "^4.3".

@alquerci

This comment has been minimized.

Copy link
Contributor Author

commented Mar 24, 2019

The Travis failure is due to symfony/messenger outdated on Packagist bdf294f instead of 326b694.

@nicolas-grekas nicolas-grekas added this to the next milestone Mar 25, 2019

@scilone scilone referenced this pull request Mar 25, 2019

Merged

Update root tree on big PR #46

@alquerci alquerci force-pushed the alquerci:v4.3-add-kernel-component branch 2 times, most recently from 456b067 to 711bdc6 Mar 25, 2019

@alquerci

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

@Korbeil @DanieleGBX I heard that you want to help in order to speed-up the merge of the new Kernel component. Any help are welcome from anyone else wants to help.

This PR provides all required code modifications, but we still needs to upgrade the documentation and to write the UPGRADE_6.0.md file. And for sure code review are welcome.

You can see the full to do list on this PR description.

@alquerci alquerci changed the title [WIP] [Kernel] Add Kernel component [Kernel] Add Kernel component Mar 31, 2019

@alquerci alquerci force-pushed the alquerci:v4.3-add-kernel-component branch from 711bdc6 to a835c82 Mar 31, 2019

@alquerci

This comment has been minimized.

Copy link
Contributor Author

commented Mar 31, 2019

As it left only to upgrade the documentation then removed [WIP].

cc @stof @nicolas-grekas @dunglas

@alquerci alquerci force-pushed the alquerci:v4.3-add-kernel-component branch from 89e19b9 to 1c0c799 Mar 31, 2019

alquerci added some commits Mar 24, 2019

[HttpKernel] Remove schedule deprecation trigger
Tests are not covered by backward compatibility promise.

@alquerci alquerci force-pushed the alquerci:v4.3-add-kernel-component branch from 1c0c799 to 0875cc7 Apr 10, 2019

@alquerci alquerci force-pushed the alquerci:v4.3-add-kernel-component branch from 8049125 to 57be6c0 Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.