Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serializer] Use name converter when normalizing constraint violation list #30717

Merged
merged 1 commit into from Apr 15, 2019

Conversation

Projects
None yet
4 participants
@norkunas
Copy link
Contributor

commented Mar 27, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

When using name converter with serializer and the default ConstraintViolationListNormalizer, returned propertyPaths was not converted to the same format.

@norkunas norkunas changed the title Use name converter when normalizing constraint violation list [Serializer] Use name converter when normalizing constraint violation list Mar 27, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone Mar 28, 2019

@norkunas norkunas force-pushed the norkunas:missing-piece branch from 3133b76 to dd93b70 Apr 7, 2019

@dunglas

dunglas approved these changes Apr 7, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

Thank you @norkunas.

@nicolas-grekas nicolas-grekas merged commit dd93b70 into symfony:master Apr 15, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Apr 15, 2019

feature #30717 [Serializer] Use name converter when normalizing const…
…raint violation list (norkunas)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Serializer] Use name converter when normalizing constraint violation list

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | no
| New feature?  | yes <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

When using name converter with serializer and the default ConstraintViolationListNormalizer, returned propertyPaths was not converted to the same format.

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

dd93b70 Use name converter when normalizing constraint violation list

@norkunas norkunas deleted the norkunas:missing-piece branch Apr 15, 2019

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.