Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] use "nyholm/psr7" by default in Psr18Client #30752

Merged
merged 1 commit into from Mar 28, 2019

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Copy link
Member

commented Mar 28, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This makes the factory arguments of Psr18Client optional, with a fallback to using Nyholm\Psr7\Factory\Psr17Factory when no factories are provided.

@Nyholm

Nyholm approved these changes Mar 28, 2019

Copy link
Member

left a comment

This is a nice way to provide a simpler way to create the PSR18Client.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:psr18 branch from bd6b09c to 0d90c47 Mar 28, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:psr18 branch from 0d90c47 to f2222e4 Mar 28, 2019

@nicolas-grekas nicolas-grekas merged commit f2222e4 into symfony:master Mar 28, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Mar 28, 2019

feature #30752 [HttpClient] use "nyholm/psr7" by default in Psr18Clie…
…nt (nicolas-grekas)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[HttpClient] use "nyholm/psr7" by default in Psr18Client

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This makes the factory arguments of `Psr18Client` optional, with a fallback to using `Nyholm\Psr7\Factory\Psr17Factory` when no factories are provided.

Commits
-------

f2222e4 [HttpClient] use "nyholm/psr7" by default in Psr18Client

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:psr18 branch Mar 28, 2019

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.