Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PropertyAccess] Allow Can Accessor in Property Access #30758

Merged
merged 1 commit into from Mar 31, 2019

Conversation

Projects
None yet
4 participants
@ragboyjr
Copy link
Contributor

commented Mar 28, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR
  • Added ability to support can methods in the property access
    in order to be compatible with PropertyInfo component
    which allows for can accessors
[PropertyAccess] Allow Can Accessor in Property Access
- Added ability to support `can` methods in the property access
  in order to be compatible with PropertyInfo component
  which allows for can accessors

Signed-off-by: RJ Garcia <rj@bighead.net>
@fabpot

fabpot approved these changes Mar 29, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone Mar 31, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Mar 31, 2019

Thank you @ragboyjr.

@fabpot fabpot merged commit a4c9574 into symfony:master Mar 31, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Mar 31, 2019

feature #30758 [PropertyAccess] Allow Can Accessor in Property Access…
… (ragboyjr)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[PropertyAccess] Allow Can Accessor in Property Access

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets |
| License       | MIT
| Doc PR        |

- Added ability to support `can` methods in the property access
  in order to be compatible with PropertyInfo component
  which allows for `can` accessors

Commits
-------

a4c9574 [PropertyAccess] Allow Can Accessor in Property Access

@ragboyjr ragboyjr deleted the ragboyjr:allow-can-in-property-access branch Apr 1, 2019

@ragboyjr

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

Thanks!

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.