Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Process] Added more detail to the exception when the CWD is invalid #30815

Merged
merged 1 commit into from Apr 1, 2019

Conversation

Projects
None yet
4 participants
@lyrixx
Copy link
Member

lyrixx commented Apr 1, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

When using panther with "special" directory structure, the message is
not really usefull. Let's add the CWD to the exception

@fabpot

fabpot approved these changes Apr 1, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Apr 1, 2019

Thank you @lyrixx.

@fabpot fabpot merged commit d27858f into symfony:master Apr 1, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Apr 1, 2019

minor #30815 [Process] Added more detail to the exception when the CW…
…D is invalid (lyrixx)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Process] Added more detail to the exception when the CWD is invalid

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

---

When using panther with "special" directory structure, the message is
not really usefull. Let's add the CWD to the exception

Commits
-------

d27858f [Process] Added more detail to the exception when the CWD is invalid

@lyrixx lyrixx deleted the lyrixx:process-exception branch Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.