Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient][Contracts] rename "raw_headers" to "response_headers" #30831

Merged
merged 1 commit into from Apr 2, 2019

Conversation

Projects
None yet
5 participants
@nicolas-grekas
Copy link
Member

commented Apr 2, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

A preliminary step before adding the request_headers info on responses to ease debugging.

@nicolas-grekas nicolas-grekas added this to the next milestone Apr 2, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:hc-req-headers branch from 32346ce to 0b21268 Apr 2, 2019

@fabpot

fabpot approved these changes Apr 2, 2019

@chalasr

chalasr approved these changes Apr 2, 2019

@chalasr chalasr added the HttpClient label Apr 2, 2019

@nicolas-grekas nicolas-grekas merged commit 0b21268 into symfony:master Apr 2, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Apr 2, 2019

minor #30831 [HttpClient][Contracts] rename "raw_headers" to "respons…
…e_headers" (nicolas-grekas)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[HttpClient][Contracts] rename "raw_headers" to "response_headers"

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

A preliminary step before adding the `request_headers` info on responses to ease debugging.

Commits
-------

0b21268 [HttpClient][Contracts] rename "raw_headers" to "response_headers"

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:hc-req-headers branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.