Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cache] add logs on early-recomputation and locking #30844

Merged
merged 1 commit into from Apr 3, 2019

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Copy link
Member

commented Apr 3, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -
@fabpot

fabpot approved these changes Apr 3, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

Thank you @nicolas-grekas.

@@ -82,13 +83,13 @@ function (CacheItem $item, float $startTime, ?array &$metadata) {
try {
$value = $callbackWrapper($callback, $item, $save, $pool, function (CacheItem $item) use ($setMetadata, $startTime, &$metadata) {
$setMetadata($item, $startTime, $metadata);
});
}, $this->logger ?? null);

This comment has been minimized.

Copy link
@bendavies

bendavies Apr 3, 2019

Contributor

$this->logger is sufficient?

@fabpot fabpot merged commit 847a9bb into symfony:master Apr 3, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Apr 3, 2019

feature #30844 [Cache] add logs on early-recomputation and locking (n…
…icolas-grekas)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Cache] add logs on early-recomputation and locking

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

847a9bb [Cache] add logs on early-recomputation and locking

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:cache-log branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.