Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[HttpClient] Adjust logger messages and levels #30873
I already make app that heavily use an http client with a nice log platform, and I never add such need. So you really think it common to search by verb or URL ?
@nicolas-grekas About warning vs debug:
Warning do not spam the logs.
I suppose you are referring to the FingerCrossHandler. But the threshold is
So, maybe some warning should goes to debug. But I'm not sure it's the case for all of them.
$this->logger && $this->logger->info(sprintf('Rejecting pushed response for "%s": authorization headers don\'t match the request', $url));
Could you re-review this PR with theses new considerations? Thanks