Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow] Fixed initial places when no places are configured #30884

Merged
merged 1 commit into from Apr 6, 2019

Conversation

Projects
None yet
4 participants
@lyrixx
Copy link
Member

lyrixx commented Apr 6, 2019

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations?
Tests pass? yes
Fixed tickets
License MIT
Doc PR

EUFOSSA

I introduced a BC break in #30468 and this PR fix it.
With the full stack framework, when one does not configure the
initial_place(s) the DIC set [] for the initial values.
So it removes the initials values guessed in Definition::addPlace()

[Workflow] Fixed initial places when no places are configured
I introduced a BC break in #30468 and this PR fix it.
With the full stack framework, when one does not configure the
initial_place(s) the DIC set `[]` for the initial values.
So it removes the initials values guessed in `Definition::addPlace()`

@lyrixx lyrixx force-pushed the lyrixx:workflow-fix branch from 8f3a2e5 to 76fd9c3 Apr 6, 2019

@fabpot

fabpot approved these changes Apr 6, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Apr 6, 2019

Thank you @lyrixx.

@fabpot fabpot merged commit 76fd9c3 into symfony:master Apr 6, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Apr 6, 2019

bug #30884 [Workflow] Fixed initial places when no places are configu…
…red (lyrixx)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Workflow] Fixed initial places when no places are configured

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? |
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

EUFOSSA

I introduced a BC break in #30468 and this PR fix it.
With the full stack framework, when one does not configure the
initial_place(s) the DIC set `[]` for the initial values.
So it removes the initials values guessed in `Definition::addPlace()`

Commits
-------

76fd9c3 [Workflow] Fixed initial places when no places are configured

@lyrixx lyrixx deleted the lyrixx:workflow-fix branch Apr 6, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone Apr 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.