Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] fix search in debug autowiring #30887

Conversation

Projects
None yet
8 participants
@Simperfit
Copy link
Contributor

commented Apr 6, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30493
License MIT
Doc PR

Taking #30522 and finishing it with @nicolas-grekas comments.
Is the sentence ok ?

@Simperfit Simperfit force-pushed the Simperfit:feature/fix-search-in-debug-autowiring branch 2 times, most recently from cff1c8e to bfe246c Apr 6, 2019

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

@chalasr @fabpot PR is ready, the message has been changed.

@chalasr

chalasr approved these changes Apr 6, 2019

@Simperfit Simperfit force-pushed the Simperfit:feature/fix-search-in-debug-autowiring branch 2 times, most recently from cbec3df to 92155ec Apr 6, 2019

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

@nicolas-grekas updated

@soufianZantar

This comment has been minimized.

Copy link
Contributor

commented Apr 6, 2019

I spent my time in debbuging and crating my PR, and i waiting for the back from 24days, @Simperfit it's normal for you to create new PR after the back of @nicolas-grekas ????

@chalasr it's normal to close my PR and not this PR?

@Simperfit Simperfit force-pushed the Simperfit:feature/fix-search-in-debug-autowiring branch from 92155ec to c965a17 Apr 6, 2019

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

@soufianZantar Firstly Thanks very much for the contribution to the Symfony framework, We are at a hackathon, we wanted to move things forward by taking the stalling PRs to finish them.

You still have the work done with the commit included in the PR, again thanks very much, I just took what you have done and updated it while talking to @nicolas-grekas.

@Simperfit Simperfit force-pushed the Simperfit:feature/fix-search-in-debug-autowiring branch from c965a17 to a535bdb Apr 6, 2019

@soufianZantar

This comment has been minimized.

Copy link
Contributor

commented Apr 6, 2019

Ok, I understood now. No problem.

@greg0ire

This comment has been minimized.

Copy link
Contributor

commented Apr 6, 2019

If you want to get credit for that PR, you can do so by associating the email address for what seems to be an alternate account (@sez-open ?) to your @soufianZantar account. With love from the hackathon: https://twitter.com/hashtag/EUFOSSA

@Simperfit Simperfit force-pushed the Simperfit:feature/fix-search-in-debug-autowiring branch from a535bdb to fec4bea Apr 7, 2019

@chalasr

chalasr approved these changes Apr 7, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

Thank you @Simperfit.

@nicolas-grekas nicolas-grekas merged commit fec4bea into symfony:master Apr 7, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Apr 7, 2019

feature #30887 [FrameworkBundle] fix search in debug autowiring (sez-…
…open)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[FrameworkBundle] fix search in debug autowiring

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #30493   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        |

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Taking #30522 and finishing it with @nicolas-grekas comments.
Is the sentence ok ?

Commits
-------

fec4bea fix debug:autowiringcommand
@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

And thank you @soufianZantar

@Simperfit Simperfit deleted the Simperfit:feature/fix-search-in-debug-autowiring branch Apr 7, 2019

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.