Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DIC] Add a `require` env var processor #30897

Merged
merged 1 commit into from Apr 7, 2019

Conversation

Projects
None yet
7 participants
@mpdude
Copy link
Contributor

commented Apr 6, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR symfony/symfony-docs#11313

This adds a new require processor that will require() the PHP file given as input value and return the value returned from that file. Leverages opcaching (yay!).

#EUFOSSA

@mpdude

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

Before I forget: Can I (or who can) add the FOSSHackathon label?

@mpdude

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

I guess tests are failing due to some other issue...?

@stof

This comment has been minimized.

Copy link
Member

commented Apr 6, 2019

@mpdude you should add the hashtags in the PR description (allowing to find all these issues and PR through the github search, even on multiple repos)

@stof

This comment has been minimized.

Copy link
Member

commented Apr 6, 2019

this requires either a doc PR or at least a doc issue.

@mpdude

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

Doc PR added.

@mpdude

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

you should add the hashtags in the PR description (allowing to find all these issues and PR through the github search, even on multiple repos)

@stof Not sure I understand how to do this

@xabbuh xabbuh added this to the next milestone Apr 6, 2019

@mpdude

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

Regarding the failed tests, every test run fails due to different reasons. In all cases, I don't see how that would be related to this PR.

Add a `require` env var processor
This allows to process .php files, returning the value returned
from that file. Leverages the opcache.

@mpdude mpdude force-pushed the mpdude:require_env_processor branch from 60ad78a to 03da3a2 Apr 7, 2019

@mpdude

This comment has been minimized.

Copy link
Contributor Author

commented Apr 7, 2019

Rebased on master to give Travis/CI tests another try.

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

Thank you @mpdude.

@nicolas-grekas nicolas-grekas merged commit 03da3a2 into symfony:master Apr 7, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Apr 7, 2019

feature #30897 [DIC] Add a `require` env var processor (mpdude)
This PR was merged into the 4.3-dev branch.

Discussion
----------

[DIC] Add a `require` env var processor

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        | symfony/symfony-docs#11313

This adds a new `require` processor that will `require()` the PHP file given as input value and return the value `return`ed from that file. Leverages opcaching (yay!).

#EUFOSSA

Commits
-------

03da3a2 Add a `require` env var processor

@mpdude mpdude deleted the mpdude:require_env_processor branch Apr 7, 2019

wouterj added a commit to symfony/symfony-docs that referenced this pull request Apr 7, 2019

feature #11313 Add documentation for the `require` env processor (mpd…
…ude)

This PR was squashed before being merged into the master branch (closes #11313).

Discussion
----------

Add documentation for the `require` env processor

Documentation for symfony/symfony#30897, discussed on the FOSSHackathon.

Commits
-------

1011b42 Add documentation for the `require` env processor

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.