Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] add new `Timezone` validation constraint #30900

Merged
merged 1 commit into from Apr 6, 2019

Conversation

@hhamon
Copy link
Contributor

commented Apr 6, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT
Doc PR symfony/symfony-docs#11317

Rework of #22262.

@hhamon hhamon force-pushed the hhamon:tz_validator branch from 6783f94 to ce70747 Apr 6, 2019

@hhamon hhamon referenced this pull request Apr 6, 2019

Closed

[Validator] Add `TimezoneValidator` #22262

2 of 2 tasks complete

@hhamon hhamon force-pushed the hhamon:tz_validator branch 3 times, most recently from 8e03af4 to 6b6c8d0 Apr 6, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone Apr 6, 2019

@hhamon hhamon force-pushed the hhamon:tz_validator branch from 6b6c8d0 to f87bf3b Apr 6, 2019

@hhamon

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

Also documentation PR is on its way as well ;)

@hhamon hhamon force-pushed the hhamon:tz_validator branch from f87bf3b to 6016ca8 Apr 6, 2019

@hhamon hhamon changed the title Add new `TimezoneValidator` [Validator] add new `Timezone` validation constraint Apr 6, 2019

@hhamon hhamon force-pushed the hhamon:tz_validator branch from 6016ca8 to 9f7ed5a Apr 6, 2019

@xabbuh

xabbuh approved these changes Apr 6, 2019

Copy link
Member

left a comment

with a minor change request

@hhamon hhamon force-pushed the hhamon:tz_validator branch 2 times, most recently from f13c04b to e619668 Apr 6, 2019

@hhamon hhamon force-pushed the hhamon:tz_validator branch from e619668 to 1675760 Apr 6, 2019

@hhamon hhamon force-pushed the hhamon:tz_validator branch from 1675760 to 536e53f Apr 6, 2019

@fabpot

fabpot approved these changes Apr 6, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Apr 6, 2019

Thank you @hhamon.

@fabpot fabpot merged commit 536e53f into symfony:master Apr 6, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Apr 6, 2019

feature #30900 [Validator] add new `Timezone` validation constraint (…
…phansys)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Validator] add new `Timezone` validation constraint

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT
| Doc PR        | symfony/symfony-docs#11317

Rework of #22262.

Commits
-------

536e53f [Validator] add new `Timezone` validation constraint.

@hhamon hhamon deleted the hhamon:tz_validator branch Apr 6, 2019

wouterj added a commit to symfony/symfony-docs that referenced this pull request Apr 7, 2019

feature #11317 [Validator] add documentation for the new `Timezone` c…
…onstraint. (hhamon, javiereguiluz)

This PR was merged into the master branch.

Discussion
----------

[Validator] add documentation for the new `Timezone` constraint.

This is the documentation related to PR symfony/symfony#30900

Commits
-------

8e33d47 Fixes classification
5ec9159 Fix option
ec7bd40 Revert country_code to countryCode
9cbeb75 Fixes options list table
c5681bf Add more explanations
b37bc78 Minor fixes
d564218 Minor fixes
ac6282f Listed the geographical zones defined by PHP
135c5ff Minor fixes
b0b1498 [Validator] add documentation for the new `Timezone` constraint.
@ro0NL

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

do we still consider #22262 (review)?

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.