Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[symfony/HttpKernel] Throws an error when the generated class name is invalid. #30906

Merged
merged 1 commit into from Apr 6, 2019

Conversation

Projects
None yet
5 participants
@drupol
Copy link
Contributor

drupol commented Apr 6, 2019

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30845
License MIT

@nicolas-grekas nicolas-grekas added this to the next milestone Apr 6, 2019

@drupol drupol force-pushed the drupol:30845-invalid-classname-generation branch from 83c8dcb to d9e7269 Apr 6, 2019

@drupol drupol changed the title Issue #30845: Throws an error when the generated class name is invalid. [symfony/HttpKernel] Throws an error when the generated class name is invalid. Apr 6, 2019

Show resolved Hide resolved src/Symfony/Component/HttpKernel/Kernel.php Outdated
@fabpot

fabpot approved these changes Apr 6, 2019

@fabpot fabpot force-pushed the drupol:30845-invalid-classname-generation branch from 1fd718a to c976866 Apr 6, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Apr 6, 2019

Thank you @drupol.

@fabpot fabpot merged commit c976866 into symfony:master Apr 6, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Apr 6, 2019

feature #30906 [symfony/HttpKernel] Throws an error when the generate…
…d class name is invalid. (drupol)

This PR was squashed before being merged into the 4.3-dev branch (closes #30906).

Discussion
----------

[symfony/HttpKernel] Throws an error when the generated class name is invalid.

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30845
| License       | MIT

Commits
-------

c976866 [symfony/HttpKernel] Throws an error when the generated class name is invalid.

@drupol drupol deleted the drupol:30845-invalid-classname-generation branch Apr 6, 2019

alquerci added a commit to alquerci/symfony that referenced this pull request Apr 10, 2019

feature symfony#30906 [symfony/HttpKernel] Throws an error when the g…
…enerated class name is invalid. (drupol)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.