Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messenger] Uses an `AmqpStamp` to provide flags and attributes #30913

Merged

Conversation

Projects
None yet
4 participants
@sroze
Copy link
Member

commented Apr 6, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28885
License MIT
Doc PR ø

Using the AmqpStamp you can configure the flags and any attribute (such as delivery_mode).

@sroze sroze force-pushed the sroze:feature-28885-custom-flags-and-attributes branch from 6d76faa to 6d6a5f7 Apr 6, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone Apr 6, 2019

@nicolas-grekas
Copy link
Member

left a comment

LGTM with minor comments.

@sroze sroze force-pushed the sroze:feature-28885-custom-flags-and-attributes branch 2 times, most recently from df31f55 to ee068a3 Apr 6, 2019

@sroze sroze force-pushed the sroze:feature-28885-custom-flags-and-attributes branch from ee068a3 to 56fa574 Apr 6, 2019

@fabpot

fabpot approved these changes Apr 6, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Apr 6, 2019

Thank you @sroze.

@fabpot fabpot merged commit 56fa574 into symfony:master Apr 6, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Apr 6, 2019

feature #30913 [Messenger] Uses an `AmqpStamp` to provide flags and a…
…ttributes (sroze)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Messenger] Uses an `AmqpStamp` to provide flags and attributes

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28885
| License       | MIT
| Doc PR        | ø

Using the `AmqpStamp` you can configure the flags and any attribute (such as `delivery_mode`).

Commits
-------

56fa574 Uses an `AmqpStamp` to provide flags and attributes

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.