Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DependencyInjection] fix tests #30928

Merged
merged 1 commit into from Apr 7, 2019

Conversation

Projects
None yet
5 participants
@xabbuh
Copy link
Member

xabbuh commented Apr 6, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

#FOSSHackathons #EUFOSSA

@xabbuh xabbuh added this to the 3.4 milestone Apr 6, 2019

@xabbuh xabbuh force-pushed the xabbuh:pr-30889 branch 2 times, most recently from 8ee31a8 to f4e60f2 Apr 6, 2019

@xabbuh xabbuh changed the title [DependencyInjection] fix PHPUnit 4.8 compatibility [DependencyInjection] fix tests Apr 6, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Apr 6, 2019

@xabbuh There is still one failing test. Can you have a look?

@xabbuh

This comment has been minimized.

Copy link
Member Author

xabbuh commented Apr 6, 2019

I am going to check.

@xabbuh xabbuh force-pushed the xabbuh:pr-30889 branch from f4e60f2 to 0d30eba Apr 6, 2019

@xabbuh xabbuh force-pushed the xabbuh:pr-30889 branch from 0d30eba to e55f6e6 Apr 6, 2019

@xabbuh

This comment has been minimized.

Copy link
Member Author

xabbuh commented Apr 6, 2019

finally green \o/

@Simperfit

This comment has been minimized.

Copy link
Contributor

Simperfit commented Apr 6, 2019

@lyrixx

lyrixx approved these changes Apr 7, 2019

@fabpot

fabpot approved these changes Apr 7, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Apr 7, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit e55f6e6 into symfony:3.4 Apr 7, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Apr 7, 2019

minor #30928 [DependencyInjection] fix tests (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

[DependencyInjection] fix tests

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

#FOSSHackathons #EUFOSSA

Commits
-------

e55f6e6 fix tests

@xabbuh xabbuh deleted the xabbuh:pr-30889 branch Apr 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.