Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Routing][ObjectRouteLoader] Allow invokable route loader services #30933

Merged

Conversation

Projects
None yet
5 participants
@fancyweb
Copy link
Contributor

commented Apr 6, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR symfony/symfony-docs#11333

#eufossa

Fall back by default on the __invoke method when it is not configured.

Using a regex is easier to check that the format is valid, at least for the time we have to supports the single column notation.

TODO :

  • Changelog entry
  • Doc PR

@fancyweb fancyweb force-pushed the fancyweb:object-router-loader-invoke branch from db1a736 to 13ad1d0 Apr 6, 2019

@chalasr chalasr added this to the next milestone Apr 7, 2019

@fancyweb fancyweb force-pushed the fancyweb:object-router-loader-invoke branch from 13ad1d0 to 5bf7ad4 Apr 7, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

Thank you @fancyweb.

@nicolas-grekas nicolas-grekas merged commit 5bf7ad4 into symfony:master Apr 7, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Apr 7, 2019

feature #30933 [Routing][ObjectRouteLoader] Allow invokable route loa…
…der services (fancyweb)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Routing][ObjectRouteLoader] Allow invokable route loader services

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | symfony/symfony-docs#11333

#eufossa

Fall back by default on the `__invoke` method when it is not configured.

Using a regex is easier to check that the format is valid, at least for the time we have to supports the single column notation.

TODO :
- [x] Changelog entry
- [x] Doc PR

Commits
-------

5bf7ad4 [Routing][ObjectRouteLoader] Allow invokable route loader services

wouterj added a commit to symfony/symfony-docs that referenced this pull request Apr 7, 2019

feature #11333 [Routing] Invokable route loader services (fancyweb)
This PR was merged into the master branch.

Discussion
----------

[Routing] Invokable route loader services

#eufossa

doc for symfony/symfony#30933

Also the notation with one column has been deprecated so I updated this part as well.

Commits
-------

d9b4121 [Routing] Invokable route loader services

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.