Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lock test suite #30944

Merged
merged 1 commit into from Apr 7, 2019

Conversation

Projects
None yet
8 participants
@jderusse
Copy link
Contributor

jderusse commented Apr 7, 2019

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets na
License MIT
Doc PR na
@chalasr

This comment has been minimized.

Copy link
Member

chalasr commented Apr 7, 2019

@jderusse jderusse force-pushed the jderusse:fix-test branch from 38db5d9 to 91fb586 Apr 7, 2019

@chalasr

chalasr approved these changes Apr 7, 2019

@lyrixx

lyrixx approved these changes Apr 7, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Apr 7, 2019

Tests are still broken apparently.

@sroze

This comment has been minimized.

Copy link
Member

sroze commented Apr 7, 2019

Still failing on deps=low:

1) Symfony\Component\Lock\Tests\Store\StoreFactoryTest::testCreateStore with data set #7 ('memcached://server.com', 'Symfony\Component\Lock\Store\...dStore')
Error: Class 'Symfony\Component\Cache\Adapter\AbstractAdapter' not found

@jderusse jderusse force-pushed the jderusse:fix-test branch from 91fb586 to 2bb1d52 Apr 7, 2019

@jderusse

This comment has been minimized.

Copy link
Contributor Author

jderusse commented Apr 7, 2019

code changed @approvers: (check if the Adapter exists)

@jderusse jderusse force-pushed the jderusse:fix-test branch from 2bb1d52 to 1f66e7b Apr 7, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Apr 7, 2019

Thank you @jderusse.

@fabpot fabpot merged commit 1f66e7b into symfony:master Apr 7, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Apr 7, 2019

minor #30944 Fix Lock test suite (jderusse)
This PR was merged into the 4.3-dev branch.

Discussion
----------

Fix Lock test suite

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | na
| License       | MIT
| Doc PR        | na

Commits
-------

1f66e7b Fix Lock test suite

@nicolas-grekas nicolas-grekas added this to the next milestone Apr 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.