Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] [Validator] Add missing french validators translations #30945

Merged

Conversation

Projects
None yet
7 participants
@hhamon
Copy link
Contributor

hhamon commented Apr 7, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets ~
License MIT
Doc PR ~
@javiereguiluz

This comment has been minimized.

Copy link
Member

javiereguiluz commented Apr 7, 2019

Very nice! We'd also include another new translation. See #30946.

@hhamon

This comment has been minimized.

Copy link
Contributor Author

hhamon commented Apr 7, 2019

Thanks Javier!

I've put the french translation for the compromised password constraint in @xabbuh's PR so that he can update the file accordingly :)

@lyrixx

lyrixx approved these changes Apr 7, 2019

@hhamon hhamon force-pushed the hhamon:validator-add-missing-french-translations branch 3 times, most recently from 6f980d4 to 5cfd0d0 Apr 7, 2019

@hhamon hhamon changed the title [3.4] [Validator] Add missing french validators translation [3.4] [Validator] Add missing french validators translations Apr 7, 2019

@xabbuh xabbuh dismissed their stale review Apr 7, 2019

I don't know anything abot French

@hhamon hhamon force-pushed the hhamon:validator-add-missing-french-translations branch 4 times, most recently from 8d35900 to 0883342 Apr 7, 2019

@hhamon hhamon force-pushed the hhamon:validator-add-missing-french-translations branch from 0883342 to 331b601 Apr 7, 2019

@hhamon

This comment has been minimized.

Copy link
Contributor Author

hhamon commented Apr 7, 2019

I think it's good to go!

@fabpot

fabpot approved these changes Apr 7, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Apr 7, 2019

Thank you @hhamon.

@fabpot fabpot merged commit 331b601 into symfony:3.4 Apr 7, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Apr 7, 2019

minor #30945 [3.4] [Validator] Add missing french validators translat…
…ions (hhamon)

This PR was merged into the 3.4 branch.

Discussion
----------

[3.4] [Validator] Add missing french validators translations

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

Commits
-------

331b601 [3.4] [Validator] Add missing french validation translations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.