Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] [TwigBundle] Move the hinclude key away from templating #30959

Conversation

@Simperfit
Copy link
Contributor

commented Apr 7, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets #30874
License MIT
Doc PR to do when pr is validated.

Maybe I shouldn't move directly the config key from templating to the other, but since the templating component has been deprecated we may change this directly without deprecating that key alone, WDYT ?

@Simperfit Simperfit force-pushed the Simperfit:feature/remove-hinclude-from-templating-and-give-it-to-fragments branch from c045b3d to e6dfc08 Apr 7, 2019

@Simperfit Simperfit force-pushed the Simperfit:feature/remove-hinclude-from-templating-and-give-it-to-fragments branch from e6dfc08 to 2957e52 Apr 7, 2019

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented Apr 7, 2019

done @stof @fabpot

@Simperfit Simperfit force-pushed the Simperfit:feature/remove-hinclude-from-templating-and-give-it-to-fragments branch from 2957e52 to 98c6732 Apr 7, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone Apr 7, 2019

@Simperfit Simperfit force-pushed the Simperfit:feature/remove-hinclude-from-templating-and-give-it-to-fragments branch from 98c6732 to f53edb0 Apr 7, 2019

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented Apr 7, 2019

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented Apr 7, 2019

@Simperfit Simperfit force-pushed the Simperfit:feature/remove-hinclude-from-templating-and-give-it-to-fragments branch from f53edb0 to 0a0d913 Apr 8, 2019

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

I've added an existence check to not replace if it has been already setted.

@Simperfit Simperfit force-pushed the Simperfit:feature/remove-hinclude-from-templating-and-give-it-to-fragments branch from 3c89d11 to 2ee4331 Apr 8, 2019

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

@fabpot Should be ok now, I've added a test.

@Simperfit Simperfit force-pushed the Simperfit:feature/remove-hinclude-from-templating-and-give-it-to-fragments branch from 2ee4331 to 400ed9a Apr 8, 2019

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

@fabpot PR ready, CI failure not related to this PR.

@Simperfit Simperfit force-pushed the Simperfit:feature/remove-hinclude-from-templating-and-give-it-to-fragments branch from 400ed9a to 7fb7329 Apr 8, 2019

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

done @fabpot

@Simperfit Simperfit force-pushed the Simperfit:feature/remove-hinclude-from-templating-and-give-it-to-fragments branch from 7fb7329 to 2dfcc51 Apr 8, 2019

@Simperfit Simperfit force-pushed the Simperfit:feature/remove-hinclude-from-templating-and-give-it-to-fragments branch from 2dfcc51 to 9b605e9 Apr 8, 2019

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

done @fabpot

@fabpot

fabpot approved these changes Apr 8, 2019

@fabpot fabpot force-pushed the Simperfit:feature/remove-hinclude-from-templating-and-give-it-to-fragments branch from 9b605e9 to 4f39339 Apr 8, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

Thank you @Simperfit.

@fabpot fabpot merged commit 4f39339 into symfony:master Apr 8, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Apr 8, 2019

feature #30959 [FrameworkBundle] [TwigBundle] Move the hinclude key a…
…way from templating (Simperfit)

This PR was squashed before being merged into the 4.3-dev branch (closes #30959).

Discussion
----------

[FrameworkBundle] [TwigBundle] Move the hinclude key away from templating

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | yes <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #30874 <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | to do when pr is validated.

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Maybe I shouldn't move directly the config key from templating to the other, but since the templating component has been deprecated we may change this directly without deprecating that key alone, WDYT ?

Commits
-------

4f39339 [FrameworkBundle] [TwigBundle] Move the hinclude key away from templating

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.