Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serializer] Experimental for ObjectListExtractor #30963

Conversation

Projects
None yet
5 participants
@joelwurtz
Copy link
Contributor

commented Apr 7, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30904
License MIT
Doc PR -

Related to #30818

I want to mark this class as @expiremental until we have the full refactoring done of the Serializer, also this would allow change needed if some behavior was not correctly taken into care in 4.3

Mark also final for the default implementation as we don't want that to be extendable and user should use composition over inheritance.

@dunglas

dunglas approved these changes Apr 7, 2019

Copy link
Member

left a comment

When the typos will be fixed.

@joelwurtz joelwurtz force-pushed the joelwurtz:feature/object-list-extractor-expiremental branch from b6df430 to b0cdf45 Apr 7, 2019

@joelwurtz joelwurtz changed the title [Serializer] Expiremental for ObjectListExtractor [Serializer] Experimental for ObjectListExtractor Apr 7, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

Thank you @joelwurtz.

@nicolas-grekas nicolas-grekas merged commit b0cdf45 into symfony:master Apr 7, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Apr 7, 2019

feature #30963 [Serializer] Experimental for ObjectListExtractor (joe…
…lwurtz)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Serializer] Experimental for ObjectListExtractor

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30904
| License       | MIT
| Doc PR        | -

Related to #30818

I want to mark this class as `@expiremental` until we have the full refactoring done of the Serializer, also this would allow change needed if some behavior was not correctly taken into care in 4.3

Mark also `final` for the default implementation as we don't want that to be extendable and user should use composition over inheritance.

Commits
-------

b0cdf45 Set object list extractor as expiremental, and use final for default implementation

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.