Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] for Psr18HttpClient configuration #31008

Merged
merged 1 commit into from Apr 8, 2019

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

commented Apr 8, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

No need for autowiring actually here.

@fabpot

fabpot approved these changes Apr 8, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit bf89907 into symfony:master Apr 8, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Apr 8, 2019

minor #31008 [FrameworkBundle] for Psr18HttpClient configuration (nic…
…olas-grekas)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[FrameworkBundle] for Psr18HttpClient configuration

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

No need for autowiring actually here.

Commits
-------

bf89907 [FrameworkBundle] for Psr18HttpClient configuration

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:hc-conf branch Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.