Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cache] Added command for list all available cache pools #31021

Merged
merged 1 commit into from Apr 10, 2019

Conversation

Projects
None yet
5 participants
@Nyholm
Copy link
Member

commented Apr 8, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets symfony/symfony-docs#9782
License MIT
Doc PR
@chalasr

chalasr approved these changes Apr 8, 2019

Copy link
Member

left a comment

A test case would be cool though (something similar to CachePoolClearCommandTest)

@Nyholm

This comment has been minimized.

Copy link
Member Author

commented Apr 8, 2019

A test is added. Thank you for the reviews

@nicolas-grekas nicolas-grekas force-pushed the Nyholm:cache-list branch from c337b8f to 5c210e6 Apr 10, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

Thank you @Nyholm.

@nicolas-grekas nicolas-grekas merged commit 5c210e6 into symfony:master Apr 10, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Apr 10, 2019

feature #31021 [Cache] Added command for list all available cache poo…
…ls (Nyholm)

This PR was squashed before being merged into the 4.3-dev branch (closes #31021).

Discussion
----------

[Cache] Added command for list all available cache pools

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony/symfony-docs#9782
| License       | MIT
| Doc PR        |

Commits
-------

5c210e6 [Cache] Added command for list all available cache pools

wouterj added a commit to symfony/symfony-docs that referenced this pull request Apr 10, 2019

feature #11369 [Cache] Show how to list all available pools (Nyholm)
This PR was merged into the master branch.

Discussion
----------

[Cache] Show how to list all available pools

This is documentation for symfony/symfony#31021

This will fix #9782

Commits
-------

e1636aa Show how to list all available pools

@Nyholm Nyholm deleted the Nyholm:cache-list branch Apr 10, 2019

@Nyholm

This comment has been minimized.

Copy link
Member Author

commented Apr 10, 2019

Thank you for merging

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.