Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serializer] Deprecate calling createChildContext without the format parameter #31030

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@dbu
Copy link
Contributor

commented Apr 9, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

as discussed in #30907 deprecate omitting the format parameter when extending the AbstractNormalizer.

@javiereguiluz javiereguiluz changed the title deprecate calling createChildContext without the format parameter Deprecate calling createChildContext without the format parameter Apr 9, 2019

@dbu dbu changed the title Deprecate calling createChildContext without the format parameter [Serializer] Deprecate calling createChildContext without the format parameter Apr 9, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone Apr 9, 2019

@@ -482,8 +482,12 @@ protected function denormalizeParameter(\ReflectionClass $class, \ReflectionPara
*
* @internal

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Apr 9, 2019

Member

wait, I completely missed that this was internal
we can add the argument 3.4 now then!

This comment has been minimized.

Copy link
@dbu

dbu Apr 9, 2019

Author Contributor

is it that important though that we should add the deprecation in 3.4? i guess people jumping from 3 to 5 without going through 4 will have other problems anyways so its not important to deprecate it in 3.4.

and afaik api platform is using these things. or is it not @joelwurtz ?

This comment has been minimized.

Copy link
@stof

stof Apr 10, 2019

Member

@dbu we cannot add new deprecations in 3.4. Deprecations are always added in master.

This comment has been minimized.

Copy link
@dbu

dbu Apr 10, 2019

Author Contributor

thats what i was assuming too, hence this pull request goes against master.

so is there anything to change here or is it fine as is?

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Apr 15, 2019

Member

Thanks for the link @joelwurtz - this should be reported as a bug in api-platform: not using @internal classes/methods is not an option. ping @dunglas FYI

@dbu dbu force-pushed the dbu:serializer-cache-key-method-deprecation branch from d5b0776 to fb73b72 Apr 26, 2019

@dbu

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

i updated to your comments @nicolas-grekas . okay like this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.