Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS Fixes: Not double split with one array argument #31063

Merged
merged 1 commit into from Apr 11, 2019

Conversation

Projects
None yet
4 participants
@rubenrua
Copy link
Contributor

rubenrua commented Apr 10, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets None
License MIT
Doc PR None

Keep to use the same CS in all the Symfony code base.

Use:

$resolver->setDefaults([
    'compound' => false
]);

Instead of:

$resolver->setDefaults(
    [
        'compound' => false,
    ]
);

Keep the double split when the method has two or more arguments.

I miss a PSR with this rule.

@rubenrua rubenrua force-pushed the rubenrua:fix_code_standards branch from 43029a4 to 9561b4a Apr 10, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Apr 10, 2019

Have you done the changes manually? Because we need to apply it first on 3.4 and then upwards.

@rubenrua

This comment has been minimized.

Copy link
Contributor Author

rubenrua commented Apr 10, 2019

Yes, I used a macro in emacs. I can do a new pull request to 3.4

@rubenrua rubenrua force-pushed the rubenrua:fix_code_standards branch from 9561b4a to cedf651 Apr 10, 2019

@rubenrua

This comment has been minimized.

Copy link
Contributor Author

rubenrua commented Apr 10, 2019

check #31064

fabpot added a commit that referenced this pull request Apr 10, 2019

minor #31064 CS Fixes: Not double split with one array argument (rube…
…nrua)

This PR was merged into the 3.4 branch.

Discussion
----------

CS Fixes: Not double split with one array argument

| Q             | A
| ------------- | ---
| Branch?       |  3.4  (master from #31063)
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | None
| License       | MIT
| Doc PR        | None

Keep to use the same CS in all the Symfony code base.

Use:
```php
$resolver->setDefaults([
    'compound' => false
]);
```

Instead of:
```php
$resolver->setDefaults(
    [
        'compound' => false,
    ]
);
```

Keep the double split when the method has two or more arguments.

I miss a PSR with this rule.

Commits
-------

a56bf55 CS Fixes: Not double split with one array argument

@nicolas-grekas nicolas-grekas added this to the next milestone Apr 11, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Apr 11, 2019

PRs for 3.4 and 4.2 are now merged up to master, please rebase to see if anything remains for master.

CS Fixes: Not double split with one array argument
Keep to use the same CS in all the Symfony code base.

Use:
```php
$resolver->setDefaults([
    'compound' => false
]);
```

Instead of:
```php
$resolver->setDefaults(
    [
        'compound' => false,
    ]
);
```

Keep the double split when the method has two or more arguments.

I miss a PSR with this rule.

@rubenrua rubenrua force-pushed the rubenrua:fix_code_standards branch from cedf651 to 027bd12 Apr 11, 2019

@rubenrua

This comment has been minimized.

Copy link
Contributor Author

rubenrua commented Apr 11, 2019

Done

@fabpot

fabpot approved these changes Apr 11, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Apr 11, 2019

Thank you @rubenrua.

@fabpot fabpot merged commit 027bd12 into symfony:master Apr 11, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Apr 11, 2019

minor #31063 CS Fixes: Not double split with one array argument (rube…
…nrua)

This PR was merged into the 4.3-dev branch.

Discussion
----------

CS Fixes: Not double split with one array argument

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | None
| License       | MIT
| Doc PR        | None

Keep to use the same CS in all the Symfony code base.

Use:
```php
$resolver->setDefaults([
    'compound' => false
]);
```

Instead of:
```php
$resolver->setDefaults(
    [
        'compound' => false,
    ]
);
```

Keep the double split when the method has two or more arguments.

I miss a PSR with this rule.

Commits
-------

027bd12 CS Fixes: Not double split with one array argument
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.