Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS Fixes: Not double split with one array argument #31064

Merged
merged 1 commit into from Apr 10, 2019

Conversation

Projects
None yet
4 participants
@rubenrua
Copy link
Contributor

rubenrua commented Apr 10, 2019

Q A
Branch? 3.4 (master from #31063)
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets None
License MIT
Doc PR None

Keep to use the same CS in all the Symfony code base.

Use:

$resolver->setDefaults([
    'compound' => false
]);

Instead of:

$resolver->setDefaults(
    [
        'compound' => false,
    ]
);

Keep the double split when the method has two or more arguments.

I miss a PSR with this rule.

CS Fixes: Not double split with one array argument
Keep to use the same CS in all the Symfony code base.

Use:
```php
$resolver->setDefaults([
    'compound' => false
]);
```

Instead of:
```php
$resolver->setDefaults(
    [
        'compound' => false,
    ]
);
```

Keep the double split when the method has two or more arguments.

I miss a PSR with this rule.
@fabpot

fabpot approved these changes Apr 10, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Apr 10, 2019

Good catch, thanks @rubenrua.

@fabpot fabpot merged commit a56bf55 into symfony:3.4 Apr 10, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Apr 10, 2019

minor #31064 CS Fixes: Not double split with one array argument (rube…
…nrua)

This PR was merged into the 3.4 branch.

Discussion
----------

CS Fixes: Not double split with one array argument

| Q             | A
| ------------- | ---
| Branch?       |  3.4  (master from #31063)
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | None
| License       | MIT
| Doc PR        | None

Keep to use the same CS in all the Symfony code base.

Use:
```php
$resolver->setDefaults([
    'compound' => false
]);
```

Instead of:
```php
$resolver->setDefaults(
    [
        'compound' => false,
    ]
);
```

Keep the double split when the method has two or more arguments.

I miss a PSR with this rule.

Commits
-------

a56bf55 CS Fixes: Not double split with one array argument
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Apr 10, 2019

I've just merged 3.4 into 4.2. Can you check if we need another PR for 4.2?

@rubenrua

This comment has been minimized.

Copy link
Contributor Author

rubenrua commented Apr 11, 2019

For 4.2, please check my workmate's pull request #31072

nicolas-grekas added a commit that referenced this pull request Apr 11, 2019

minor #31072 CS Fixes: Not double split with one array argument (Yuru…
…jai)

This PR was merged into the 4.2 branch.

Discussion
----------

CS Fixes: Not double split with one array argument

| Q             | A
| ------------- | ---
| Branch?       |  4.2
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | none

Fix for #31064 (comment)

Commits
-------

93dabbc CS Fixes: Not double split with one array argument
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.