Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize SVGs #31067

Merged
merged 1 commit into from Apr 11, 2019

Conversation

Projects
None yet
5 participants
@MartijnCuppens
Copy link
Contributor

commented Apr 10, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets /
License MIT
Doc PR /

Used svgo to optimize the svgs. I kept the viewBox attribute to keep the aspects when SVGs are rescaled.

I also added insert_final_newline = false to the .editorconfig file because the newlines are removed from the SVGs and there's only one line left.

@ro0NL

ro0NL approved these changes Apr 11, 2019

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Apr 11, 2019

@nicolas-grekas
Copy link
Member

left a comment

It looks like this breaks tests, can you have a look please?

Show resolved Hide resolved .editorconfig Outdated

@MartijnCuppens MartijnCuppens force-pushed the MartijnCuppens:34-optimize-svg branch 2 times, most recently from 369067c to ea9b80c Apr 11, 2019

@MartijnCuppens MartijnCuppens force-pushed the MartijnCuppens:34-optimize-svg branch from ea9b80c to 4614cea Apr 11, 2019

@MartijnCuppens

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

Anyone who can help me with the tests? Not sure what's causing these fails.

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

Thank you @MartijnCuppens.

@nicolas-grekas nicolas-grekas merged commit 4614cea into symfony:3.4 Apr 11, 2019

1 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

nicolas-grekas added a commit that referenced this pull request Apr 11, 2019

minor #31067 Optimize SVGs (MartijnCuppens)
This PR was merged into the 3.4 branch.

Discussion
----------

Optimize SVGs

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | /   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | / <!-- required for new features -->

Used [svgo](https://github.com/svg/svgo) to optimize the svgs. I kept the `viewBox` attribute to keep the aspects when SVGs are rescaled.

I also added `insert_final_newline = false` to the `.editorconfig` file because the newlines are removed from the SVGs and there's only one line left.

Commits
-------

4614cea Optimize SVGs
@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

there might be more in 4.2 if you want to have a look btw

@MartijnCuppens MartijnCuppens deleted the MartijnCuppens:34-optimize-svg branch Apr 11, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

I just optimized them on 4.2 and master, because tests were failing otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.