Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that logged URL is the same as the one which is requested. #31069

Merged
merged 1 commit into from Apr 11, 2019

Conversation

Projects
None yet
3 participants
@drupol
Copy link
Contributor

commented Apr 10, 2019

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #31068
License MIT
@nicolas-grekas
Copy link
Member

left a comment

good catch! just a small comment and good to me

@drupol drupol force-pushed the drupol:31068-httpclient-logged-url branch from 56f5861 to 9cd162a Apr 11, 2019

@nicolas-grekas nicolas-grekas force-pushed the drupol:31068-httpclient-logged-url branch from df1230d to 526cad6 Apr 11, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

Thank you @drupol.

@nicolas-grekas nicolas-grekas merged commit 526cad6 into symfony:master Apr 11, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Apr 11, 2019

bug #31069 Make sure that logged URL is the same as the one which is …
…requested. (drupol)

This PR was squashed before being merged into the 4.3-dev branch (closes #31069).

Discussion
----------

Make sure that logged URL is the same as the one which is requested.

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31068
| License       | MIT

Commits
-------

526cad6 Make sure that logged URL is the same as the one which is requested.

@drupol drupol deleted the drupol:31068-httpclient-logged-url branch Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.