Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#30998 Fix deprecated setCircularReferenceHandler call #31073

Merged

Conversation

Projects
None yet
3 participants
@dhaarbrink
Copy link
Contributor

commented Apr 11, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30998
License MIT

Instead of calling the setCircularReferenceHandler() method, it puts the handler in the default context.

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

It looks like the issue exists also on 3.4, isn't it?
Can you please rebase+retarget for 3.4?
Beware that you will have to use PHP5.5 compatible syntax.

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Apr 11, 2019

@dhaarbrink

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

No, the deprecation is from 4.2 onward: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php#L142

Should my PR be PHP5.5 compatible for v4.2?

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

Oh, sorry. 4.2 is PHP7.1, so all good then.

@nicolas-grekas nicolas-grekas modified the milestones: 3.4, 4.2 Apr 11, 2019

@nicolas-grekas nicolas-grekas force-pushed the dhaarbrink:bug/circular-reference-handler branch from 36fafc4 to 3a68040 Apr 11, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

Thank you @dhaarbrink.

@nicolas-grekas nicolas-grekas merged commit 3a68040 into symfony:master Apr 11, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Apr 11, 2019

bug #31073 #30998 Fix deprecated setCircularReferenceHandler call (dh…
…aarbrink)

This PR was squashed before being merged into the 4.3-dev branch (closes #31073).

Discussion
----------

#30998 Fix deprecated setCircularReferenceHandler call

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30998
| License       | MIT

Instead of calling the `setCircularReferenceHandler()` method, it puts the handler in the default context.

Commits
-------

3a68040 #30998 Fix deprecated setCircularReferenceHandler call

@dhaarbrink dhaarbrink deleted the dhaarbrink:bug/circular-reference-handler branch Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.