Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: the meaning of the data breach was not correct #31074

Merged
merged 1 commit into from Apr 11, 2019

Conversation

Projects
None yet
3 participants
@Simperfit
Copy link
Contributor

commented Apr 11, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets none
License MIT
Doc PR none

It seems that the french translation was wrong as the phrasing suggested that the data breach came from the current application/website.

Changing as discussed here: #31053 (comment)

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

CI Failure is not related.

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Apr 11, 2019

@nicolas-grekas nicolas-grekas force-pushed the Simperfit:patch-4 branch from 3b46cf8 to 97ac9ba Apr 11, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

Thank you @Simperfit.

@nicolas-grekas nicolas-grekas merged commit 97ac9ba into symfony:3.4 Apr 11, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Apr 11, 2019

minor #31074 minor: the meaning of the data breach was not correct (S…
…imperfit)

This PR was squashed before being merged into the 3.4 branch (closes #31074).

Discussion
----------

 minor: the meaning of the data breach was not correct

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | none  <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | none <!-- required for new features -->

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

It seems that the french translation was wrong as the phrasing suggested that the data breach came from the current application/website.

Changing as discussed here: #31053 (comment)

Commits
-------

97ac9ba  minor: the meaning of the data breach was not correct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.