Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpKernel] Fixed LoggerDataCollector crashing on empty file #31076

Merged
merged 1 commit into from Apr 11, 2019

Conversation

Projects
None yet
3 participants
@althaus
Copy link
Contributor

commented Apr 11, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #31050
License MIT

This PR adds a check to the LoggerDataCollector if there's acutal some content in the log file.

@althaus althaus changed the title Fixed LoggerDataCollector crashing on empty file [HttpKernel] Fixed LoggerDataCollector crashing on empty file Apr 11, 2019

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Apr 11, 2019

@nicolas-grekas
Copy link
Member

left a comment

(for 3.4)

@nicolas-grekas nicolas-grekas changed the base branch from 4.2 to 3.4 Apr 11, 2019

@nicolas-grekas nicolas-grekas force-pushed the althaus:31050-fix-logger-data-collector branch from 9fded1f to 291c73a Apr 11, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

Thank you @althaus.

@nicolas-grekas nicolas-grekas merged commit 291c73a into symfony:3.4 Apr 11, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Apr 11, 2019

bug #31076 [HttpKernel] Fixed LoggerDataCollector crashing on empty f…
…ile (althaus)

This PR was submitted for the 4.2 branch but it was merged into the 3.4 branch instead (closes #31076).

Discussion
----------

[HttpKernel] Fixed LoggerDataCollector crashing on empty file

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31050
| License       | MIT

This PR adds a check to the LoggerDataCollector if there's acutal some content in the log file.

Commits
-------

291c73a Catch empty deprecation.log silently (fixes #31050)

@althaus althaus deleted the althaus:31050-fix-logger-data-collector branch Apr 12, 2019

This was referenced Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.