Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] Show all option normalizers on debug:form command #31082

Merged
merged 1 commit into from Apr 15, 2019

Conversation

Projects
None yet
6 participants
@yceruto
Copy link
Contributor

commented Apr 11, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT

Follow-up #30371

normalizers

@yceruto yceruto force-pushed the yceruto:debug_form_option_normalizers branch 3 times, most recently from 713fdc6 to 90bc7f7 Apr 11, 2019

@yceruto yceruto requested a review from xabbuh as a code owner Apr 11, 2019

@xabbuh xabbuh added this to the next milestone Apr 12, 2019

@OskarStark

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

A bit of topic but as you are on it... In the Allowed types section shouldn’t it be null without quotes? 🤔

@yceruto

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2019

Hi @OskarStark, the output is consistent with its definition, we pass 'null' as allowed type:

$resolver->setAllowedTypes('query_builder', ['null', 'callable', 'Doctrine\ORM\QueryBuilder']);

@yceruto yceruto force-pushed the yceruto:debug_form_option_normalizers branch from 90bc7f7 to f1d3bc0 Apr 15, 2019

@yceruto

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

Rebased and conflict fixed

@fabpot

fabpot approved these changes Apr 15, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

Thank you @yceruto.

@fabpot fabpot merged commit f1d3bc0 into symfony:master Apr 15, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Apr 15, 2019

feature #31082 [Form] Show all option normalizers on debug:form comma…
…nd (yceruto)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Form] Show all option normalizers on debug:form command

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT

Follow-up #30371

![normalizers](https://user-images.githubusercontent.com/2028198/55996454-6667df80-5c85-11e9-94f6-9ee3988833f3.png)

Commits
-------

f1d3bc0 Show all option normalizers on debug:form command

@yceruto yceruto deleted the yceruto:debug_form_option_normalizers branch Apr 15, 2019

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.