Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] fix removing non-shared definition while inlining them #31088

Merged
merged 1 commit into from Apr 12, 2019

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

commented Apr 12, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29628
License MIT
Doc PR -

I didn't manage to create a specific test case but this still has 100% coverage for the added lines and fixed the reproducer (and makes sense also :) )

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone Apr 12, 2019

@nicolas-grekas nicolas-grekas changed the base branch from master to 4.2 Apr 12, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:di-fix-inline-non-shared branch from 212798b to 317e820 Apr 12, 2019

@Simperfit

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

Thanks for fixing it !

@nicolas-grekas nicolas-grekas merged commit 317e820 into symfony:4.2 Apr 12, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Apr 12, 2019

bug #31088 [DI] fix removing non-shared definition while inlining the…
…m (nicolas-grekas)

This PR was merged into the 4.2 branch.

Discussion
----------

[DI] fix removing non-shared definition while inlining them

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29628
| License       | MIT
| Doc PR        | -

I didn't manage to create a specific test case but this still has 100% coverage for the added lines and fixed the reproducer (and makes sense also :) )

Commits
-------

317e820 [DI] fix removing non-shared definition while inlining them

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:di-fix-inline-non-shared branch Apr 14, 2019

@fabpot fabpot referenced this pull request Apr 16, 2019

Merged

Release v4.2.6 #31125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.