Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PhpUnitBridge] ClockMock does not mock gmdate() #31093

Merged

Conversation

Projects
None yet
3 participants
@Simperfit
Copy link
Contributor

commented Apr 12, 2019

Q A
Branch? feature
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30393
License MIT
Doc PR symfony/symfony-docs#11418

Adding the feature to mock gmdate directly in ClockMock.

@Simperfit Simperfit force-pushed the Simperfit:feature/add-gmdate-mock-in-clock-mock branch from 4046438 to 3d5c6be Apr 12, 2019

@Simperfit Simperfit force-pushed the Simperfit:feature/add-gmdate-mock-in-clock-mock branch from 3d5c6be to b34738b Apr 12, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone Apr 12, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

Thank you @Simperfit.

@nicolas-grekas nicolas-grekas merged commit b34738b into symfony:master Apr 12, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Apr 12, 2019

feature #31093 [PhpUnitBridge] ClockMock does not mock gmdate() (Simp…
…erfit)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[PhpUnitBridge] ClockMock does not mock gmdate()

| Q             | A
| ------------- | ---
| Branch?       | feature
| Bug fix?      | no
| New feature?  | yes <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #30393   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#11418 <!-- required for new features -->

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->
Adding the feature to mock gmdate directly in ClockMock.

Commits
-------

b34738b [PhpUnitBridge] ClockMock does not mock gmdate()

@Simperfit Simperfit deleted the Simperfit:feature/add-gmdate-mock-in-clock-mock branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.