Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PhpUnitBridge] fixes #31094

Merged
merged 1 commit into from Apr 12, 2019

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

commented Apr 12, 2019

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Fixes @stof's review in #29211 + fixes PHP5.5 support (array consts are PHP5.6+)
/cc @greg0ire

@nicolas-grekas nicolas-grekas added this to the next milestone Apr 12, 2019

@nicolas-grekas nicolas-grekas merged commit b11585e into symfony:master Apr 12, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Apr 12, 2019

bug #31094 [PhpUnitBridge] fixes (nicolas-grekas)
This PR was merged into the 4.3-dev branch.

Discussion
----------

[PhpUnitBridge] fixes

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Fixes @stof's review in #29211 + fixes PHP5.5 support (array consts are PHP5.6+)
/cc @greg0ire

Commits
-------

b11585e [PhpUnitBridge] fixes

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:phpunit-fix branch Apr 12, 2019

@greg0ire

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2019

Thanks @nicolas-grekas !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.