Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip testing the phpunit-bridge on not-master branches when $deps is empty #31095

Merged
merged 1 commit into from Apr 12, 2019

Conversation

Projects
None yet
2 participants
@nicolas-grekas
Copy link
Member

commented Apr 12, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Tests are not in sync with the autoloaded code on these jobs.
The bridge is still tested on deps=low/high jobs + master

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Apr 12, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:test-fix branch from fa99ac6 to 3f1cc9b Apr 12, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:test-fix branch from 3f1cc9b to b0ee192 Apr 12, 2019

@nicolas-grekas nicolas-grekas merged commit b0ee192 into symfony:3.4 Apr 12, 2019

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Doing some proofreading and checking your coding style.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

nicolas-grekas added a commit that referenced this pull request Apr 12, 2019

minor #31095 Skip testing the phpunit-bridge on not-master branches w…
…hen $deps is empty (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

Skip testing the phpunit-bridge on not-master branches when $deps is empty

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Tests are not in sync with the autoloaded code on these jobs.
The bridge is still tested on deps=low/high jobs + master

Commits
-------

b0ee192 Skip testing the phpunit-bridge on not-master branches when $deps is empty

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:test-fix branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.