Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VarDumper] add caster for WeakReference instances of PHP 7.4 #31130

Merged
merged 1 commit into from Apr 18, 2019

Conversation

Projects
None yet
5 participants
@nicolas-grekas
Copy link
Member

commented Apr 16, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

image

@nicolas-grekas nicolas-grekas added this to the next milestone Apr 16, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:vd-weakref branch from 5b49437 to 99df182 Apr 16, 2019

@stof

stof approved these changes Apr 16, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:vd-weakref branch from 99df182 to 0cdb808 Apr 16, 2019

@lyrixx

lyrixx approved these changes Apr 17, 2019

@fabpot

fabpot approved these changes Apr 18, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 0cdb808 into symfony:master Apr 18, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Apr 18, 2019

feature #31130 [VarDumper] add caster for WeakReference instances of …
…PHP 7.4 (nicolas-grekas)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[VarDumper] add caster for WeakReference instances of PHP 7.4

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

![image](https://user-images.githubusercontent.com/243674/56214443-2d9d8100-605e-11e9-86bb-157a07b5caa0.png)

Commits
-------

0cdb808 [VarDumper] add caster for WeakReference instances of PHP 7.4

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:vd-weakref branch Apr 18, 2019

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.