Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] added improve support for collection validation #31196

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@Simperfit
Copy link
Contributor

commented Apr 22, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets to set
License MIT
Doc PR to do

I've taken #9988, what's missing here @webmozart ?

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

Can you please squash + review the CS?

@Simperfit Simperfit force-pushed the Simperfit:feature/improve-support-for-collection branch from fcfb4af to 36f0176 Apr 26, 2019

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

@Simperfit Simperfit force-pushed the Simperfit:feature/improve-support-for-collection branch from 654a846 to 1f7be1f Apr 26, 2019

@xabbuh

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

Can you add an entry to the Validator component CHANGELOG.md file?

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2019

changelog added, PR rebased with master.

@Simperfit Simperfit force-pushed the Simperfit:feature/improve-support-for-collection branch from 1f7be1f to fb26d1f Apr 27, 2019

@Simperfit Simperfit changed the title [Validator] added improve support for collection validation [WIP][Validator] added improve support for collection validation Apr 27, 2019

@Simperfit Simperfit changed the title [WIP][Validator] added improve support for collection validation [Validator] added improve support for collection validation Apr 27, 2019

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2019

Validators and test rewrited.

@Simperfit Simperfit force-pushed the Simperfit:feature/improve-support-for-collection branch 2 times, most recently from d16e041 to 9206395 Apr 27, 2019

@Simperfit Simperfit force-pushed the Simperfit:feature/improve-support-for-collection branch from 9206395 to 20f9edd Apr 30, 2019

@Simperfit Simperfit force-pushed the Simperfit:feature/improve-support-for-collection branch from 20f9edd to 59a8f1d May 1, 2019

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

Thanks @elementaire for the review.

@Simperfit Simperfit force-pushed the Simperfit:feature/improve-support-for-collection branch from 59a8f1d to 4d05d1d May 8, 2019

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

Status: Needs Review

@Simperfit Simperfit force-pushed the Simperfit:feature/improve-support-for-collection branch from 4d05d1d to 20aa208 May 12, 2019

@Simperfit Simperfit force-pushed the Simperfit:feature/improve-support-for-collection branch from 20aa208 to 9997afc May 15, 2019

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

@xabbuh reviex fixed and test too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.