Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwigBridge] bootstrap4 file_widget: allow setting label attributes declared in label_attr #31220

Merged
merged 992 commits into from Apr 27, 2019

Conversation

@AngelFQC
Copy link
Contributor

commented Apr 24, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets ...
License MIT
Doc PR ...

Bootstrap provides a way to translate the “Browse” text in HTML with the data-browse attribute which can be added to the custom input label.

https://getbootstrap.com/docs/4.3/components/forms/#translating-or-customizing-the-strings-with-html

But currently the attributes declared in label_attr aren't being added.

Previously I sent this same change to the master branch (PR #31102), but I think I should have sent it to branch 4.2

weaverryan and others added some commits Apr 4, 2019

minor #30864 [Messenger] fixing unused variable names (weaverryan)
This PR was merged into the 4.3-dev branch.

Discussion
----------

[Messenger] fixing unused variable names

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/30757/files#r272061245
| License       | MIT
| Doc PR        | n/a

Typo on the variable name - variables aren't needed anyways.

Cheers!

Commits
-------

f7ec2d3 fixing unused variable names
feature #30537 [HttpClient] logger integration (antonch1989, nicolas-…
…grekas)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[HttpClient] logger integration

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #30502   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        |

Commits
-------

26d15c8 [HttpClient] log requests, responses and pushes when they happen
fc6ba7e [HttpClient] logger integration
minor #30873 [HttpClient] Adjust logger messages and levels (lyrixx)
This PR was squashed before being merged into the 4.3-dev branch (closes #30873).

Discussion
----------

[HttpClient] Adjust logger messages and levels

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

098a7ac [HttpClient] Adjust logger messages and levels
minor #30880 minor: remove the logger as it seems uneeded (Simperfit)
This PR was merged into the 4.3-dev branch.

Discussion
----------

minor: remove the logger as it seems uneeded

| Q             | A
| ------------- | ---
| Branch?       | master for features
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | none  <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | not needed
<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

It seems that the logger is not used in here cc @nicolas-grekas, to close if it's the wanted code.
#euchackaton

Commits
-------

4fc6033 minor: remove the logger as it seems uneeded
feature #29097 [Messenger] Add a "in-memory://" transport (GaryPEGEOT…
…, sroze)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Messenger] Add a "in-memory://" transport

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29040
| License       | MIT
| Doc PR        | Todo

Add a new `InMemoryTransport` for test purpose, usable by starting your DSN by `in-memory://`

Commits
-------

8f8c82e Make the in-memory transport resettable
fe75920 Add a "null://" transport
bug #30881 [Messenger] Fixed DIC config when the messenger is not ins…
…talled (lyrixx)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Messenger] Fixed DIC config when the messenger is not installed

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

EUFOSSA

---

Fix:

```

In getConsole_Command_MessengerStopWorkersService.php line 9:

  Attempted to load class "StopWorkersCommand" from namespace "Symfony\Component\Messenger\Command".
  Did you forget a "use" statement for another namespace?

```

Commits
-------

292021b [Messenger] Fixed DIC config when the messenger is not installed
minor #30857 [Messenger] test DoctrineTransport on travis and appveyo…
…r (vincenttouzet)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Messenger] test DoctrineTransport on travis and appveyor

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes ? WIP
| Fixed tickets |
| License       | MIT
| Doc PR        |

Currently tests on the `Symfony\Component\Messenger\Tests\Transport\Doctrine\DoctrineIntegrationTest` are skipped because there is no `MESSENGER_DOCTRINE_DSN` environment variable is not defined.

This PR update the travis and AppVeyor configuration to run these tests.

This is a WIP. I'm not a Travis/AppVeyor user so this clearly need more work

Commits
-------

8f81f55 [Messenger] test DoctrineTransport on travis and appveyor
minor #29525 [Messenger] Make MessengerPass less strict when auto-reg…
…ister handlers (nicholasruunu)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Messenger] Make MessengerPass less strict when auto-register handlers

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT
| Doc PR        | not needed

This allows you to auto-register handlers that have more than one argument, which is useful when having custom middleware to pass more parameters.

#symfonyconhackday2018

Commits
-------

49ab2cd Make MessengerPass less strict when auto-register handlers
[Workflow] Fixed initial places when no places are configured
I introduced a BC break in #30468 and this PR fix it.
With the full stack framework, when one does not configure the
initial_place(s) the DIC set `[]` for the initial values.
So it removes the initials values guessed in `Definition::addPlace()`
bug #30886 [Workflow] Fixed Guard Listener usage of RoleHierarchyInte…
…rface (lyrixx)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Workflow] Fixed Guard Listener usage of RoleHierarchyInterface

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

EUFOSSA

related to #30388

Commits
-------

a12b359 [Workflow] Fixed Guard Listener usage of RoleHierarchyInterface
bug #30884 [Workflow] Fixed initial places when no places are configu…
…red (lyrixx)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Workflow] Fixed initial places when no places are configured

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? |
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

EUFOSSA

I introduced a BC break in #30468 and this PR fix it.
With the full stack framework, when one does not configure the
initial_place(s) the DIC set `[]` for the initial values.
So it removes the initials values guessed in `Definition::addPlace()`

Commits
-------

76fd9c3 [Workflow] Fixed initial places when no places are configured
feature #30008 [messenger] Adds a stamp to provide a routing key on m…
…essage publishing (G15N, sroze)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[messenger] Adds a stamp to provide a routing key on message publishing

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29950
| License       | MIT
| Doc PR        | symfony/symfony-docs#11236

Adds a stamp allowing to set a `routing_key` at `MessageBus::dispatch()` level.

```php
$message = (new Envelope('message'))->with(new RoutingKeyStamp('routing_key'));
$bus->dispatch($message);
```

Commits
-------

a515635 Simply code and rename "configuration" to "options"
3151b54 [messenger] AMQP configurable routing key & multiple queues
Ensure message is handled only once per handler
Add check to ensure that a message is only handled once per handler
Add try...catch to run all handlers before throwing exception
feature #30545 #30536 PropertyAccessor->getValue disable exception (d…
…imabory)

This PR was merged into the 4.3-dev branch.

Discussion
----------

#30536 PropertyAccessor->getValue disable exception

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30536
| License       | MIT
| Doc PR        | symfony/symfony-docs#11156

Commits
-------

c336696 [PropertyAccess] Allow to disable exception on invalid property path when using PropertyAccess::getValue()
feature #30020 [Messenger] Ensure message is handled only once per ha…
…ndler (keulinho, sroze)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Messenger] Ensure message is handled only once per handler

Add check to ensure that a message is only handled once per handler
Add try...catch to run all handlers before throwing exception

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? |no
| Tests pass?   | yes
| Fixed tickets | #27215
| License       | MIT
| Doc PR        | Todo

This would make error handling and retrying of messages much more easier. As statet  here #27008 (comment) there is currently no way to retry a for all failed handlers if there are mutliple handlers and just some throw an exception.
Also if an Exception in an handler occurs the execution chain is disrupted and the other handlers are never invoked.
With this change it is easily possible to create an userland middleware that catches the `ChainedHandlerFailedException` and does some custom retry logic. If you ensure that the `HandledStamps` on the `Envelope` are preserved the message will be handled just by the failed handlers

Commits
-------

2e5e910 Rename exception, add change log and a few other things
e6e4cde Ensure message is handled only once per handler
@fabpot

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

This looks like a new feature to me, right?

@AngelFQC

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

@fabpot No. Well I think no, because the html attributes defined in a form with label_attrcurrently are not being printed in label html tag... so it a bug :)

chalasr and others added some commits Apr 25, 2019

minor #31251 [FrameworkBundle] Drop unused private method (chalasr)
This PR was merged into the 4.3-dev branch.

Discussion
----------

[FrameworkBundle] Drop unused private method

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | n/a
| New feature?  | n/a
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

1e9a9b2 [FrameworkBundle] Drop unused private method
feature #31204 [Messenger] ease testing and allow forking the middlew…
…are stack (nicolas-grekas)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Messenger] ease testing and allow forking the middleware stack

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31179
| License       | MIT
| Doc PR        | -

A less radical alternative than #31185 that preserves laziness and addresses the linked issue.

Commits
-------

3bdf4b0 [Messenger] ease testing and allow forking the middleware stack
@xabbuh

xabbuh approved these changes Apr 27, 2019

ro0NL and others added some commits Apr 27, 2019

minor #31285 [Intl] Add tests (ro0NL)
This PR was merged into the 4.3-dev branch.

Discussion
----------

[Intl] Add tests

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes (including intl-data group)
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

95f09fd [Intl] Add tests
Merge branch '4.2'
* 4.2:
  Fix url matcher edge cases with trailing slash
  [Form] Fix author tag + exception messages
  [TwigBridge] Fix deprecation on twig 2.9
  Fix left-associative ternary deprecation warnings for PHP 7.4
  [Validator] Fixed imprecise translations
  [Validator] Add Dutch translations
  [Security] Cleanup "Digest nonce has expired." translation
  Intercept redirections only for HTML format
  [PhpUnitBridge] fix reading phpunit.xml on bootstrap
  resolve class name parameters
  Fix name and phpdoc of ContainerBuilder::removeBindings
  [Intl] Update the ICU data to 64.2
bug #31254 [EventDispatcher] Fix TraceableEventDispatcher FC/BC layer…
… (chalasr)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[EventDispatcher] Fix TraceableEventDispatcher FC/BC layer

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | n/a
| Tests pass?   | yes
| Fixed tickets | #31221
| License       | MIT
| Doc PR        | n/a

also renames `WrappedEvent` to `LegacyEventProxy`

Commits
-------

c5b3b34 [EventDispatcher] Fix TraceableEventDispatcher FC/BC layer
@fabpot

fabpot approved these changes Apr 27, 2019

@fabpot fabpot changed the base branch from 4.2 to master Apr 27, 2019

@AngelFQC AngelFQC requested review from dunglas, lyrixx and sroze as code owners Apr 27, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

Thank you @AngelFQC.

@fabpot fabpot merged commit 9c76b29 into symfony:master Apr 27, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build cancelled
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Apr 27, 2019

feature #31220 [TwigBridge] bootstrap4 file_widget: allow setting lab…
…el attributes declared in label_attr (AngelFQC)

This PR was submitted for the 4.2 branch but it was merged into the 4.3-dev branch instead (closes #31220).

Discussion
----------

[TwigBridge] bootstrap4 file_widget: allow setting label attributes declared in label_attr

| Q             | A
| ------------- | ---
| Branch?       | 4.2 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | ...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | ... <!-- required for new features -->

> Bootstrap provides a way to translate the “Browse” text in HTML with the data-browse attribute which can be added to the custom input label.

https://getbootstrap.com/docs/4.3/components/forms/#translating-or-customizing-the-strings-with-html

But currently the attributes declared in label_attr aren't being added.

Previously I sent this same change to the master branch (PR #31102), but I think I should have sent it to branch 4.2

Commits
-------

9c76b29 [TwigBridge] bootstrap4 file_widget: allow setting label attributes declared in label_attr
@xabbuh

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

@fabpot IMO we should have merged this as a bugfix. The FileType was the only type where it was not possible to do this.

@SerheyDolgushev

This comment has been minimized.

Sorry, it causes some issues on Platform.sh. As there PHP 7.2 comes with Redis 3.1.2.
Are there any specific reasons why 3.1.3 is required?

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.