Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Translator] Add sources when dumping qt files #31248

Merged
merged 1 commit into from Apr 29, 2019

Conversation

Projects
None yet
4 participants
@Stadly
Copy link
Contributor

commented Apr 25, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

This PR implements similar functionality as #30909, but for Qt files. Currently, only the Qt element location is supported, so only sources metadata is included in the dump.

@Stadly

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2019

I don't think the failing build has anything to do with this PR.

@nicolas-grekas nicolas-grekas added this to the next milestone Apr 26, 2019

@fabpot

fabpot approved these changes Apr 29, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

Thank you @Stadly.

@fabpot fabpot merged commit ff7577d into symfony:master Apr 29, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Apr 29, 2019

feature #31248 [Translator] Add sources when dumping qt files (Stadly)
This PR was merged into the 4.3-dev branch.

Discussion
----------

[Translator] Add sources when dumping qt files

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

This PR implements similar functionality as #30909, but for Qt files. Currently, only the Qt element `location` is supported, so only `sources` metadata is included in the dump.

Commits
-------

ff7577d Add sources when dumping qt files

@Stadly Stadly deleted the Stadly:dump-sources-qt branch Apr 29, 2019

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

fabpot added a commit that referenced this pull request May 7, 2019

feature #31249 [Translator] Set sources when extracting strings from …
…php files (Stadly)

This PR was squashed before being merged into the 4.3-dev branch (closes #31249).

Discussion
----------

[Translator] Set sources when extracting strings from php files

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Set metadata about filenames and line numbers when extracting translatable strings from php files. This PR complements #30909 and #31248, as those PRs implement support for dumping the filenames and line numbers to Po and Qt file formats.

Commits
-------

f05d4e4 [Translator] Set sources when extracting strings from php files

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.