Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Commands with an alias should not be recognized as ambiguous when using register #31261

Conversation

Projects
None yet
4 participants
@Simperfit
Copy link
Contributor

commented Apr 26, 2019

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #25355
License MIT
Doc PR

I think when passing an alias, it should not be treated as a ambiguous command since it's configured to response to it.

I've pushed a commit that reproduce the bug and with this patch it does work.

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

Travis and Appveyor failure are not related.

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

2.8 is not maintained since a few months now, can you please rebase/retarget 3.4?

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Apr 26, 2019

@Simperfit Simperfit force-pushed the Simperfit:bugfix/console-commands-with-an-alias-should-no-be-ambiguous branch from 4a38b3c to b97f7fa Apr 26, 2019

@Simperfit Simperfit requested review from dunglas and lyrixx as code owners Apr 26, 2019

@Simperfit Simperfit changed the base branch from 2.8 to 3.4 Apr 26, 2019

@Simperfit Simperfit force-pushed the Simperfit:bugfix/console-commands-with-an-alias-should-no-be-ambiguous branch 3 times, most recently from 7970690 to f375167 Apr 26, 2019

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

AppVeyor Failure is not related.

@Simperfit Simperfit force-pushed the Simperfit:bugfix/console-commands-with-an-alias-should-no-be-ambiguous branch 2 times, most recently from fa68f1f to d56b88c Apr 26, 2019

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

Status: Needs Review

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

@chalasr ready for another round of review

@chalasr chalasr removed request for dunglas and lyrixx May 5, 2019

@chalasr
Copy link
Member

left a comment

LGTM for the bugfix part.

Show resolved Hide resolved src/Symfony/Component/Console/Application.php Outdated
@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

@chalasr done

Status: Needs Review.

@Simperfit Simperfit force-pushed the Simperfit:bugfix/console-commands-with-an-alias-should-no-be-ambiguous branch from d56b88c to ae7ee46 May 8, 2019

@chalasr

chalasr approved these changes May 8, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented May 9, 2019

Thank you @Simperfit.

@nicolas-grekas nicolas-grekas merged commit ae7ee46 into symfony:3.4 May 9, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request May 9, 2019

bug #31261 [Console] Commands with an alias should not be recognized …
…as ambiguous when using register (Simperfit)

This PR was merged into the 3.4 branch.

Discussion
----------

[Console] Commands with an alias should not be recognized as ambiguous when using register

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #25355
| License       | MIT
| Doc PR        |

I think when passing an alias, it should not be treated as a ambiguous command since it's configured to response to it.

I've [pushed a commit](Simperfit/symfony-reproducer@2f5209a) that reproduce the bug and with this patch it does work.

Commits
-------

ae7ee46 [Console] Commands with an alias should not be recognized as ambiguous

@Simperfit Simperfit deleted the Simperfit:bugfix/console-commands-with-an-alias-should-no-be-ambiguous branch May 9, 2019

chalasr added a commit that referenced this pull request May 14, 2019

minor #31420 [Console] optimisation getting the command when finding …
…(Simperfit)

This PR was submitted for the 4.3 branch but it was merged into the 4.4-dev branch instead (closes #31420).

Discussion
----------

[Console] optimisation getting the command when finding

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | none  <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        |
<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Following discussion with @chalasr in here #31261 (comment), first commit will be deleted  when the other PR is merged.

Commits
-------

3d6b303 [Console] Optimisation on getting the command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.