Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[Intl] Update timezones to ICU 64.2 + compile zone to country mapping #31262
This PR compiles the zone to country mapping (and vice versa) from ICU data:
I've recompiled timezones on master due #31162, i should do it once more when it's merged upstream.
Having this data allows compatibility between PHP timezones and ICU;
For the timezone validator in Symfony, this would be required to have a compatible "regions" option, once it supports ICU as well (#28836 (comment))
this ones ready, see last commit for the added timezones which are missing currently (cc @fabpot)
cc @sstok tests are passing
The main change is we use
Also a fallback was missing for e.g.
I think this nails it, and im done with timezones for a while now
@fabpot not sure :) all json files (en.json, composer.json) have trailing EOL; there are no parsing issues AFAIK. Unless you meant a different whitespace?
If it's about e.g. https://github.com/symfony/symfony/pull/31262/files#diff-5996b6b88384d2b755c17f069229882fR4 that's part of the localized interpunction; it's UTF :)