Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebServerBundle] Change the default pidfile location to cache directory #31280

Merged

Conversation

Projects
None yet
6 participants
@jschaedl
Copy link
Contributor

commented Apr 26, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29160
License MIT
Doc PR tbd.

@jschaedl jschaedl force-pushed the jschaedl:web-server-bundle_store-pidfile-project-dir branch from ae09416 to ee32c98 Apr 26, 2019

@jschaedl jschaedl marked this pull request as ready for review Apr 26, 2019

@jschaedl jschaedl changed the title Changes default pidfile location to project dir #29160 [WebServerBundle] Changes default pidfile location to project dir #29160 Apr 26, 2019

@jschaedl jschaedl changed the title [WebServerBundle] Changes default pidfile location to project dir #29160 [WebServerBundle] Changes default pidfile location to project dir Apr 26, 2019

@jschaedl jschaedl changed the title [WebServerBundle] Changes default pidfile location to project dir [WebServerBundle] Change the default pidfile location to projectDir Apr 26, 2019

@chalasr chalasr added this to the next milestone Apr 26, 2019

@jschaedl jschaedl force-pushed the jschaedl:web-server-bundle_store-pidfile-project-dir branch from ee32c98 to 3aae37d Apr 27, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

I'm still on the side this should be somewhere in the var directory.

@jschaedl jschaedl force-pushed the jschaedl:web-server-bundle_store-pidfile-project-dir branch from 74bc733 to 2be7b89 Apr 27, 2019

tests are failing

@jschaedl jschaedl changed the title [WebServerBundle] Change the default pidfile location to projectDir [WebServerBundle] Change the default pidfile location to cache directory Apr 28, 2019

@jschaedl

This comment has been minimized.

Copy link
Contributor Author

commented Apr 28, 2019

@nicolas-grekas

tests are failing

Tests are fixed but the AppVeyor build is still failing... 😕

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

By the way, not sure it's a good idea to use the parent directory of the cache directory. It may not be writable.

same issue with getcwd(), yet this is for dev, I'd guess it's because this is never an issue with dev?

@fabpot

fabpot approved these changes Apr 29, 2019

@fabpot fabpot force-pushed the jschaedl:web-server-bundle_store-pidfile-project-dir branch from 0022b33 to 2e14b6e Apr 29, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

Thank you @jschaedl.

@fabpot fabpot merged commit 2e14b6e into symfony:master Apr 29, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Apr 29, 2019

feature #31280 [WebServerBundle] Change the default pidfile location …
…to cache directory (jschaedl)

This PR was squashed before being merged into the 4.3-dev branch (closes #31280).

Discussion
----------

[WebServerBundle] Change the default pidfile location to cache directory

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #29160   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | tbd.

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

2e14b6e [WebServerBundle] Change the default pidfile location to cache directory

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.