Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] Add intl/choice_translation_locale option to TimezoneType #31294

Merged
merged 1 commit into from May 13, 2019

Conversation

@ro0NL
Copy link
Contributor

commented Apr 27, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28836
License MIT
Doc PR symfony/symfony-docs#11503

final step :)

for now i think any form of grouping is a user concern (i.e. by GMT offset or area name); see #31293 + #31295

having a special built in group_by' => 'gmt_offset' util would be nice, and can be done in the future.

includes #31434

@ro0NL ro0NL force-pushed the ro0NL:tz-intl branch from d5c761d to ce5d899 Apr 29, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone Apr 30, 2019

@ro0NL ro0NL force-pushed the ro0NL:tz-intl branch 2 times, most recently from e25ce5a to 6fdf155 May 9, 2019

@ro0NL ro0NL marked this pull request as ready for review May 9, 2019

@yceruto

yceruto approved these changes May 9, 2019

Copy link
Contributor

left a comment

The Form part LGTM.

nicolas-grekas added a commit that referenced this pull request May 9, 2019

minor #31434 [Intl] Revise timezone name generation (ro0NL)
This PR was merged into the 4.3 branch.

Discussion
----------

 [Intl] Revise timezone name generation

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes (inlcluding intl-data group)
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

This is the final polishing needed for #31294 :)

I've realized it's much easier to de-duplicate by processing fallback locales separate, and then only keep the diff compared to a specific locale. More or less the same approach `LocaleDataGenerator` already follows. I was trying to be clever and filter based on inheritance in a single process; bad idea.

Includes ro0NL@31591d0 (ref #31432)

Commits
-------

bfdb4ed [Intl] Revise timezone name generation
@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented May 9, 2019

Time for rebase.

@ro0NL

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

4.3? would makes sense as we added all the timezone related infra in 4.3 already, which purpose it was to support this feature 😅

@ro0NL ro0NL force-pushed the ro0NL:tz-intl branch from 569ff63 to 5aa6496 May 9, 2019

@ro0NL ro0NL changed the base branch from master to 4.3 May 9, 2019

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 May 9, 2019

(red tests)

@ro0NL

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

Figured it out, locally i invoked TimezoneTypeTest direct. It passed :)

testing the whole suite, shows we have a global state issue with the default locale. Last commit should do, not sure why it starts failing now, as other intl types have the same test :/

@ro0NL ro0NL force-pushed the ro0NL:tz-intl branch from 5aa6496 to 0a11d2c May 9, 2019

@ro0NL ro0NL requested review from dunglas, lyrixx, sroze and xabbuh as code owners May 9, 2019

@ro0NL ro0NL force-pushed the ro0NL:tz-intl branch from 357e2e3 to eaba9f2 May 9, 2019

fabpot added a commit that referenced this pull request May 10, 2019

minor #31448 [Form] Restore default locale during tests (ro0NL)
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] Restore default locale during tests

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes-ish
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #31294 (comment)
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

This fixes the failing tests in #31294

Commits
-------

7fce86f [Form] Restore default locale during tests

@ro0NL ro0NL force-pushed the ro0NL:tz-intl branch 2 times, most recently from 428908e to f5f565d May 10, 2019

@ro0NL ro0NL force-pushed the ro0NL:tz-intl branch from f5f565d to 001b930 May 10, 2019

@ro0NL

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

All good (failures unrelated)

@fabpot

fabpot approved these changes May 13, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented May 13, 2019

Thank you @ro0NL.

@fabpot fabpot merged commit 001b930 into symfony:4.3 May 13, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request May 13, 2019

feature #31294 [Form] Add intl/choice_translation_locale option to Ti…
…mezoneType (ro0NL)

This PR was merged into the 4.3 branch.

Discussion
----------

[Form] Add intl/choice_translation_locale option to TimezoneType

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #28836
| License       | MIT
| Doc PR        | symfony/symfony-docs#11503

final step :)

for now i think any form of grouping is a user concern (i.e. by GMT offset or area name); see #31293 + #31295

having a special built in `group_by' => 'gmt_offset'` util would be nice, and can be done in the future.

includes #31434

Commits
-------

001b930 [Form] Add intl/choice_translation_locale option to TimezoneType

@ro0NL ro0NL deleted the ro0NL:tz-intl branch May 13, 2019

@fabpot fabpot referenced this pull request May 22, 2019

Merged

Release v4.3.0-BETA2 #31577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.