Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Intl] Add timezone offset utilities #31295

Merged
merged 1 commit into from Apr 29, 2019

Conversation

Projects
None yet
4 participants
@ro0NL
Copy link
Contributor

commented Apr 27, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes (including intl-data group)
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

@ro0NL ro0NL force-pushed the ro0NL:tz-offset branch from ac78c47 to 4fc914a Apr 28, 2019

@ro0NL ro0NL changed the title [Intl] Add Timezones::getGmtOffset utility [Intl] Add timezone offset utilities Apr 28, 2019

@ro0NL ro0NL force-pushed the ro0NL:tz-offset branch from 4fc914a to b166e33 Apr 28, 2019

@ro0NL

This comment has been minimized.

Copy link
Contributor Author

commented Apr 28, 2019

The GMT offset + hour format is locale aware: https://github.com/unicode-org/icu/blob/e2d85306162d3a0691b070b4f0a73e4012433444/icu4c/source/data/zone/en.txt#L723-L724

we should compile it :)

status: needs work

@fabpot

fabpot approved these changes Apr 29, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

Thank you @ro0NL.

@fabpot fabpot merged commit b166e33 into symfony:master Apr 29, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Apr 29, 2019

feature #31295 [Intl] Add timezone offset utilities (ro0NL)
This PR was merged into the 4.3-dev branch.

Discussion
----------

[Intl] Add timezone offset utilities

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes (including intl-data group)
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Commits
-------

b166e33 [Intl] Add timezone offset utilities

@nicolas-grekas nicolas-grekas added this to the next milestone Apr 29, 2019

@ro0NL ro0NL deleted the ro0NL:tz-offset branch Apr 29, 2019

fabpot added a commit that referenced this pull request Apr 29, 2019

feature #31318 [Intl] Compile localized timezone offset name (ro0NL)
This PR was merged into the 4.3-dev branch.

Discussion
----------

[Intl] Compile localized timezone offset name

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes-ish
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes (including intl-data group)
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

A tiny follow up of #31295

Commits
-------

7a40d20 [Intl] Compile localized timezone offset name

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

fabpot added a commit that referenced this pull request May 13, 2019

feature #31294 [Form] Add intl/choice_translation_locale option to Ti…
…mezoneType (ro0NL)

This PR was merged into the 4.3 branch.

Discussion
----------

[Form] Add intl/choice_translation_locale option to TimezoneType

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #28836
| License       | MIT
| Doc PR        | symfony/symfony-docs#11503

final step :)

for now i think any form of grouping is a user concern (i.e. by GMT offset or area name); see #31293 + #31295

having a special built in `group_by' => 'gmt_offset'` util would be nice, and can be done in the future.

includes #31434

Commits
-------

001b930 [Form] Add intl/choice_translation_locale option to TimezoneType
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.