Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "bug #30620 [FrameworkBundle][HttpFoundation] make session service resettable (dmaicher)" #31338

Merged
merged 1 commit into from May 1, 2019

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

commented May 1, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This reverts commit 029fb2e, reversing
changes made to 9dad29d.

Reverts #30620
Replaces #31215

We don't need to solve this in 3.4
Making the session resettable should be done on master, by implementing ResetInterface.
On 3.4 apps, one should write a dedicated SessionResetter that would implement the reverted logic.

Revert "bug #30620 [FrameworkBundle][HttpFoundation] make session ser…
…vice resettable (dmaicher)"

This reverts commit 029fb2e, reversing
changes made to 9dad29d.
@fabpot

fabpot approved these changes May 1, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented May 1, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 4177331 into symfony:3.4 May 1, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request May 1, 2019

bug #31338 Revert "bug #30620 [FrameworkBundle][HttpFoundation] make …
…session service resettable (dmaicher)" (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

Revert "bug #30620 [FrameworkBundle][HttpFoundation] make session service resettable (dmaicher)"

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This reverts commit 029fb2e, reversing
changes made to 9dad29d.

Reverts #30620
Replaces #31215

We don't need to solve this in 3.4
Making the session resettable should be done on master, by implementing `ResetInterface`.
On 3.4 apps, one should write a dedicated `SessionResetter` that would implement the reverted logic.

Commits
-------

4177331 Revert "bug #30620 [FrameworkBundle][HttpFoundation] make session service resettable (dmaicher)"

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:ses-revert branch May 1, 2019

This was referenced May 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.