Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Intl] Made countries ISO 3166 compliant + exclude Zzzz script code #31365

Merged
merged 1 commit into from May 7, 2019

Conversation

Projects
None yet
4 participants
@ro0NL
Copy link
Contributor

commented May 2, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes (including intl-data group)
Fixed tickets #31350 (comment), #18613
License MIT
Doc PR symfony/symfony-docs#...

For consistency :)

self::EUROZONE_ID => true,
self::UNITED_NATIONS_ID => true,
// No longer exists
self::NETHERLANDS_ANTILLES_ID => true,

This comment has been minimized.

Copy link
@ro0NL

ro0NL May 2, 2019

Author Contributor

removed upstream 👍

@ro0NL ro0NL force-pushed the ro0NL:intl-unknown branch from 5b24cb6 to 8fc92ee May 2, 2019

@ro0NL ro0NL force-pushed the ro0NL:intl-unknown branch from c7681db to 257e344 May 3, 2019

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone May 5, 2019

@ro0NL

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

See #31350 (comment)

it seems there are a few more codes that should be excluded before we comply with ISO-3166

@ro0NL ro0NL force-pushed the ro0NL:intl-unknown branch 5 times, most recently from 8e99665 to 6aa9033 May 6, 2019

fabpot added a commit that referenced this pull request May 7, 2019

minor #31366 [Intl] Cleanup (ro0NL)
This PR was merged into the 3.4 branch.

Discussion
----------

[Intl] Cleanup

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

cleanup of #31365 for 3.4 + some other stuff to keep in sync across branches

Commits
-------

70a941e [Intl] Cleanup
@fabpot

This comment has been minimized.

Copy link
Member

commented May 7, 2019

@ro0NL Can you rebase this one please?

@ro0NL ro0NL force-pushed the ro0NL:intl-unknown branch from 6aa9033 to 1bb7dde May 7, 2019

@ro0NL

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

@fabpot done.

@ro0NL ro0NL changed the title [Intl] Exclude invalid/unknown codes [Intl] Made countries ISO 3166 compliant + exclude Zzzz script code May 7, 2019

@fabpot

fabpot approved these changes May 7, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented May 7, 2019

Thank you @ro0NL.

@fabpot fabpot merged commit 1bb7dde into symfony:master May 7, 2019

0 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details

fabpot added a commit that referenced this pull request May 7, 2019

feature #31365 [Intl] Made countries ISO 3166 compliant + exclude Zzz…
…z script code (ro0NL)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Intl] Made countries ISO 3166 compliant + exclude Zzzz script code

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes (including intl-data group)
| Fixed tickets | #31350 (comment), #18613
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

For consistency :)

Commits
-------

1bb7dde [Intl] Made countries ISO 3166 compliant + exclude Zzzz script code

@ro0NL ro0NL deleted the ro0NL:intl-unknown branch May 7, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.