Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] optimisation getting the command when finding #31420

Merged

Conversation

Projects
None yet
5 participants
@Simperfit
Copy link
Contributor

commented May 8, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets none
License MIT
Doc PR

Following discussion with @chalasr in here #31261 (comment), first commit will be deleted when the other PR is merged.

@Simperfit Simperfit changed the title Feature/optiisation getting the command [Console] optimisation getting the command when finding May 8, 2019

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone May 9, 2019

@nicolas-grekas nicolas-grekas changed the base branch from master to 4.3 May 9, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented May 9, 2019

Time for rebase :)

@fabpot fabpot modified the milestones: 4.3, next May 10, 2019

@Simperfit Simperfit force-pushed the Simperfit:feature/optiisation-getting-the-command branch 3 times, most recently from 995f25c to abe9d57 May 12, 2019

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented May 12, 2019

@nicolas-grekas rebased

@Simperfit Simperfit force-pushed the Simperfit:feature/optiisation-getting-the-command branch from abe9d57 to 2989a05 May 12, 2019

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented May 12, 2019

Status: Needs Review

@chalasr
Copy link
Member

left a comment

Blocking merge for now, I realize that calling has() involves to instantiate some lazy commands which might be a problem even for the related bugfix, I'm going to double-check the behavior tonight.

@chalasr chalasr added the Console label May 14, 2019

@chalasr chalasr changed the base branch from 4.3 to master May 14, 2019

@chalasr chalasr force-pushed the Simperfit:feature/optiisation-getting-the-command branch from 2989a05 to 3d6b303 May 14, 2019

@chalasr

This comment has been minimized.

Copy link
Member

commented May 14, 2019

Thank you @Simperfit.

@chalasr chalasr merged commit 3d6b303 into symfony:master May 14, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

chalasr added a commit that referenced this pull request May 14, 2019

minor #31420 [Console] optimisation getting the command when finding …
…(Simperfit)

This PR was submitted for the 4.3 branch but it was merged into the 4.4-dev branch instead (closes #31420).

Discussion
----------

[Console] optimisation getting the command when finding

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | none  <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        |
<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Following discussion with @chalasr in here #31261 (comment), first commit will be deleted  when the other PR is merged.

Commits
-------

3d6b303 [Console] Optimisation on getting the command

@Simperfit Simperfit deleted the Simperfit:feature/optiisation-getting-the-command branch May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.