Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messenger] add abstract handler #31429

Open
wants to merge 1 commit into
base: 4.3
from

Conversation

@timiTao
Copy link

commented May 8, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #31417
License MIT
Doc PR symfony/symfony-docs#...

Added handling abstract handler.

@timiTao timiTao changed the title add abstract handler [Messenger] add abstract handler May 8, 2019

@timiTao timiTao force-pushed the timiTao:abstract-handler branch from d511c10 to 5ab44c7 May 8, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone May 9, 2019

@nicolas-grekas
Copy link
Member

left a comment

I'd be OK to add this for 4.3 - here are some comments before.

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 May 9, 2019

@nicolas-grekas nicolas-grekas changed the base branch from master to 4.3 May 9, 2019

@timiTao timiTao force-pushed the timiTao:abstract-handler branch from 5ab44c7 to a42682c May 9, 2019

@timiTao timiTao requested review from dunglas, lyrixx, sroze and xabbuh as code owners May 9, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented May 11, 2019

Can you please rebase -i to get rid of the extra commits?

@timiTao timiTao force-pushed the timiTao:abstract-handler branch from a42682c to 81726f1 May 11, 2019

@sroze

This comment has been minimized.

Copy link
Member

commented May 12, 2019

@timiTao can you rebase to get rid of these extra commits in your branch please?

@timiTao timiTao force-pushed the timiTao:abstract-handler branch 2 times, most recently from 800189c to 17d5a2d May 13, 2019

@juanmiguelbesada
Copy link

left a comment

In my opinion, I think is better set $container as first parameter of getDefinitionClass method (to keep consistent with other methods)

@timiTao timiTao force-pushed the timiTao:abstract-handler branch from b9b858e to c9a3f53 May 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.