Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cache] Add Redis Sentinel support #31437

Merged

Conversation

Projects
None yet
3 participants
@StephenClouse
Copy link
Contributor

commented May 9, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR symfony/symfony-docs#11545

This change adds support for Redis Sentinel clusters to the Cache component Redis adapter.

The DSN format is syntactically equivalent to cluster support, but adds a new parameter redis_sentinel that should be set to the sentinel service name.

This support requires the use of predis as the underlying connection library. The redis extension does not support sentinel at this time.

@StephenClouse StephenClouse force-pushed the StephenClouse:cache/redis-sentinel-support branch from 444e0d9 to 0d1126f May 9, 2019

@StephenClouse StephenClouse marked this pull request as ready for review May 9, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone May 9, 2019

@nicolas-grekas
Copy link
Member

left a comment

thanks, here are some comments
note that will be for 4.4: 4.3 is in maintenance mode already and accepts no new features.

Show resolved Hide resolved src/Symfony/Component/Cache/Traits/RedisTrait.php Outdated
Show resolved Hide resolved src/Symfony/Component/Cache/CHANGELOG.md Outdated
Show resolved Hide resolved src/Symfony/Component/Cache/Traits/RedisTrait.php Outdated
Show resolved Hide resolved src/Symfony/Component/Cache/Traits/RedisTrait.php Outdated

@StephenClouse StephenClouse force-pushed the StephenClouse:cache/redis-sentinel-support branch from fd178b4 to 6eb46d8 May 9, 2019

@nicolas-grekas
Copy link
Member

left a comment

(with minor comments)

Show resolved Hide resolved src/Symfony/Component/Cache/Traits/RedisTrait.php Outdated
Show resolved Hide resolved src/Symfony/Component/Cache/Traits/RedisTrait.php Outdated

@StephenClouse StephenClouse force-pushed the StephenClouse:cache/redis-sentinel-support branch from 6eb46d8 to edf6170 May 13, 2019

@nicolas-grekas nicolas-grekas changed the title Add Redis Sentinel support [Cache] Add Redis Sentinel support May 22, 2019

@nicolas-grekas nicolas-grekas force-pushed the StephenClouse:cache/redis-sentinel-support branch from edf6170 to 80e8b21 May 22, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented May 22, 2019

Thank you @StephenClouse.

@nicolas-grekas nicolas-grekas merged commit 80e8b21 into symfony:master May 22, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request May 22, 2019

feature #31437 [Cache] Add Redis Sentinel support (StephenClouse)
This PR was squashed before being merged into the 4.4-dev branch (closes #31437).

Discussion
----------

[Cache] Add Redis Sentinel support

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        | symfony/symfony-docs#11545

This change adds support for Redis Sentinel clusters to the Cache component Redis adapter.

The DSN format is syntactically equivalent to cluster support, but adds a new parameter `redis_sentinel` that should be set to the sentinel service name.

This support requires the use of predis as the underlying connection library. The redis extension does not support sentinel at this time.

Commits
-------

80e8b21 [Cache] Add Redis Sentinel support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.