Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template for 4.3 #31439

Merged
merged 1 commit into from May 9, 2019

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

commented May 9, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone May 9, 2019

@fabpot

fabpot approved these changes May 9, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented May 9, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 1532077 into symfony:3.4 May 9, 2019

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Doing some proofreading and checking your coding style.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

fabpot added a commit that referenced this pull request May 9, 2019

minor #31439 Update PR template for 4.3 (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

Update PR template for 4.3

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

1532077 Update PR template for 4.3

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:gh-pr-tpl branch May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.